Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Typo for indent rule #11666

Closed
sdev opened this issue Apr 30, 2019 · 5 comments

Comments

Projects
None yet
5 participants
@sdev
Copy link

commented Apr 30, 2019

The document for the rule "indent" has typos for some of the examples for Importdeclaration option. The quotes are missing. Please see link: https://eslint.org/docs/rules/indent

ex. 4, { ImportDeclaration: 1 } vs. 4, { "ImportDeclaration": 1 }

@eslint eslint bot added the triage label Apr 30, 2019

@g-plane g-plane added the needs info label Apr 30, 2019

@eslint

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

Hi @sdev, thanks for the issue. It looks like there's not enough information for us to know how to help you.

If you're reporting a bug, please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. What you did (the source code and ESLint configuration)
  3. The actual ESLint output complete with numbers
  4. What you expected to happen instead

Requesting a new rule? Please see Proposing a New Rule for instructions.

Requesting a rule change? Please see Proposing a Rule Change for instructions.

If it's something else, please just provide as much additional information as possible. Thanks!

@sdev

This comment has been minimized.

Copy link
Author

commented May 1, 2019

@g-plane on this link https://eslint.org/docs/rules/indent, search for term ImportDeclaration, you will find some of them are not double quoted, which is inconsistent with others, and also it does not work without the double quote. The rule is not recognized unless it is double quoted.

@platinumazure

This comment has been minimized.

Copy link
Member

commented May 1, 2019

Hi @sdev, thanks for explaining.

Quotes are required in JSON configuration files. However, what you see in the rule docs are inline configuration comments. Those accept a loose superset of JSON and don't require quotes. However, a PR would be welcome to bring everything into consistency.

@AlokTakshak

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

@platinumazure
I have updated the doc ,and raised a PR
#11679

@kaicataldo

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Closing this as It looks the corresponding PR (#11679) has been merged.

@kaicataldo kaicataldo closed this May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.