Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comma-dangle doesn't report functions when using string option #12058

Open
jwilsson opened this issue Aug 3, 2019 · 1 comment

Comments

@jwilsson
Copy link
Contributor

commented Aug 3, 2019

Tell us about your environment

  • ESLint Version: 6.1.0
  • Node Version: 12.7.0
  • npm Version: 6.10.2

What parser (default, Babel-ESLint, etc.) are you using?
default

Please show your full configuration:

Configuration
{
    "comma-dangle": ["error", "always"]
}

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

foo(a)

What did you expect to happen?
I expected it to warn about the missing trailing comma after a. This is true no matter which string option I'm using. I saw that comma-dangle changed in 6.0.0 so I'm guessing it has something to do with that.

What actually happened? Please include the actual, raw output from ESLint.
No errors were reported.

Are you willing to submit a pull request to fix this bug?
Yes

@kaicataldo kaicataldo added evaluating rule and removed triage labels Aug 3, 2019

@kaicataldo

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

Thanks for the bug report. It looks like this behavior was changed in 6.0.0. I'm leaving the bug label on here because it looks like the documentation change doesn't currently match the actual behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.