New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-trailing-spaces doesn't report trailing spaces after block comments #12479
Closed
mdjermanovic opened this issue
Oct 22, 2019
· 2 comments
· Fixed by #12480, WealthWizardsEngineering/service-registry#12, basics/vector#111, thinkwee/thinkwee.github.io#39 or alxtford/numconv#46
Closed
no-trailing-spaces doesn't report trailing spaces after block comments #12479
mdjermanovic opened this issue
Oct 22, 2019
· 2 comments
· Fixed by #12480, WealthWizardsEngineering/service-registry#12, basics/vector#111, thinkwee/thinkwee.github.io#39 or alxtford/numconv#46
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
rule
Relates to ESLint's core rules
Comments
Thanks @mdjermanovic for the issue! This seems like a pretty clear bug to me. I assume this fix will increase warnings in some cases, so it should be an Update. |
I'm working on this. |
mdjermanovic
added a commit
that referenced
this issue
Oct 22, 2019
btmills
pushed a commit
that referenced
this issue
Oct 25, 2019
This was referenced Nov 9, 2019
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
This was referenced Apr 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
rule
Relates to ESLint's core rules
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Configuration
What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.
Online Demo Link
What did you expect to happen?
1 error because the option ignores just spaces in comments, not those after comments?
What actually happened? Please include the actual, raw output from ESLint.
No errors.
Are you willing to submit a pull request to fix this bug?
Yes.
I'm not sure if this is intended behavior? I think there are no tests to confirm this.
The text was updated successfully, but these errors were encountered: