Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.7.0 broke autofixing for eslint-plugin-react #12614

Closed
ljharb opened this issue Nov 28, 2019 · 1 comment · May be fixed by rsumner868/librealsense2.1#1, rsumner868/librealsense#4, nl253/BlogUI#3, O330oei/node#4 or O330oei/node#11

Comments

@ljharb
Copy link
Contributor

@ljharb ljharb commented Nov 28, 2019

Tests pass on master in https://github.com/yannickcr/eslint-plugin-react on v6.6, and fail on v6.7.0 or v6.7.1. https://travis-ci.org/yannickcr/eslint-plugin-react/jobs/616996307 is an example of the failures; they're related to whitespace placement, within jsx.

I'm not sure which item in the changelog might be responsible, but perhaps #12491 (cc @kaicataldo)?

The change doesn't need to be reverted if i have a reliable way in the react plugin to detect the different behavior, but I suspect that's also difficult.

@ljharb ljharb added bug triage labels Nov 28, 2019
ljharb added a commit to yannickcr/eslint-plugin-react that referenced this issue Nov 28, 2019
ljharb added a commit to yannickcr/eslint-plugin-react that referenced this issue Nov 28, 2019
@mysticatea
Copy link
Member

@mysticatea mysticatea commented Nov 28, 2019

Thank you for your report.

I confirmed it.
As you mentioned, #12491 has changed the behavior of the isSpaceBetweenTokens() method about JSXText tokens that contain only spaces.

mysticatea added a commit that referenced this issue Nov 28, 2019
)
mysticatea added a commit that referenced this issue Nov 28, 2019
kaicataldo added a commit that referenced this issue Nov 30, 2019
… (#12616)

* Fix: isSpaceBetween() recognizes spaces in JSXText (fixes #12614)

* apply this fix only for isSpaceBetweenTokens()

* move tests to the section for nodes

* add tests for isSpaceBetween()

* add tests for reversed order
ljharb added a commit to ljharb/eslint-plugin-react that referenced this issue Nov 30, 2019
This reverts commit 71c7d01.

Thanks to v6.7.2 / eslint/eslint#12616 / eslint/eslint#12614
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.