Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Use consistent badge style #12825

Merged
merged 3 commits into from Feb 5, 2020
Merged

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Jan 23, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jan 23, 2020
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong preference which style we pick, but it would be nice to be consistent across all the badges if possible! Looks like we have a mix currently.

README.md Outdated Show resolved Hide resolved
@kaicataldo kaicataldo added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Jan 23, 2020
Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>
@kaicataldo
Copy link
Member

Thoughts on making the styles consistent? We now have a mix of the square and rounded corners badges.

@fisker
Copy link
Contributor Author

fisker commented Feb 5, 2020

Seems no flat square badge for FOSSA so change the other 2 badges to rounded ?

@kaicataldo
Copy link
Member

Sounds good to me!

@fisker fisker changed the title Chore: use flat-square style github actions badge Chore: Use consistent badge style Feb 5, 2020
@fisker
Copy link
Contributor Author

fisker commented Feb 5, 2020

@kaicataldo Done. README.md

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! I agree this looks nicer.

@kaicataldo kaicataldo merged commit b7f0d20 into eslint:master Feb 5, 2020
@fisker fisker deleted the actions-badge branch February 6, 2020 02:49
montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
* Chore: use flat-square style github actions badge

* Chore: Update README.md

Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>

* chore: making the badges styles consistent

Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 5, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants