New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: RuleTester Improvements (refs eslint/rfcs#25) #12955
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
added
core
Relates to ESLint's core APIs and features
accepted
There is consensus among the team that this change meets the criteria for inclusion
breaking
This change is backwards-incompatible
labels
Feb 23, 2020
aladdin-add
reviewed
Feb 23, 2020
kaicataldo
suggested changes
Mar 28, 2020
lib/rule-tester/rule-tester.js
Outdated
function defineStartEndAsErrorInTree(ast, visitorKeys) { | ||
Traverser.traverse(ast, { visitorKeys, enter: defineStartEndAsError.bind(null, "node") }); | ||
ast.tokens.forEach(defineStartEndAsError.bind(null, "token")); | ||
ast.comments.forEach(defineStartEndAsError.bind(null, "comment")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally think this should be token
instead of comment
for the sake of consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, done!
kaicataldo
moved this from Implemented, pending review
to Issues which have PR
in v7.0.0
Mar 28, 2020
kaicataldo
approved these changes
Mar 28, 2020
Thank you! |
eslint-deprecated
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
Sep 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
breaking
This change is backwards-incompatible
core
Relates to ESLint's core APIs and features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Add something to the core
refs eslint/rfcs#25
Additional validations in the RuleTester.
What changes did you make? (Give an overview)
This PR implements 1.-3. from eslint/rfcs#25
.start
and.end
properties. Test that happens to trigger such code is supposed to fail.output
property will fail if the rule has fixed the code.errors
is a number.The remaining improvement from the rfc (4. fail on unknown error properties) is in PR #12096.
Is there anything you'd like reviewers to focus on?
node.start
andnode.end
. This PR also includestoken.start
andtoken.end
(and the same for comment tokens), is it okay?"Use comment.range[0] instead of comment.start"
(as it is implemented now), or"Use token.range[0] instead of token.start"
.tests/lib/rules/spaced-comment.js
are removed, since it's no longer possible to test parsing errors.tests/lib/rules/_set-default-parser.js
file. If I understand this correctly, that file is no longer needed.