You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While the following implies the opposite, I think the text could be clarified here a bit too:
In addition to any patterns in a .eslintignore file, ESLint always ignores files in /node_modules/* and /bower_components/.
# /node_modules/ and /bower_components/* in the project root are ignored by default
The first line is confusing as it seems to suggest one cannot get linting of node_modules or bower_components yet it is possible to reenable both of them with !.
Your take on the correct solution to problem.
Remove node_modules from the examples unless to point out that one can undo the default (it may be helpful to mention that !.eslintrc.js (or !.*.js) can be added back too, at least until eslint 7 may change this behavior for !.eslintrc.js).
For the third case, I think it should instead say in the first line "ESLint always ignores files by default in ..." since I am (thankfully!) able to reapply linting of node_modules (or bower_components) by adding !node_modules/** to an ignore (within an .eslintignore file or by a command such as $(npm bin)/eslint --no-inline-config --ignore-pattern='!node_modules/**' .). (I truly hope this functionality will never be dropped, btw!)
Are you willing to submit a pull request to implement this change?
Not at this time.
The text was updated successfully, but these errors were encountered: