Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Improve report location for array-callback-return (refs #12334) #13109

Merged
merged 1 commit into from Apr 24, 2020

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Other, please explain:

refs #12334

Change reported location in the array-callback-return rule.

What changes did you make? (Give an overview)

The rule will now use astUtils.getFunctionHeadLoc instead of its own code for the reported function's location.

Differences:

  • Arrow functions
    • Start loc is unchanged (start loc of =>).
    • End loc will be the end loc of =>, instead of nothing.
  • Anonymous function expressions
    • Start loc is unchanged (start loc of the function node).
    • End loc will be start loc of the opening paren of params, instead of nothing.
  • Named function expression:
    • Start loc will be start loc of the function node, instead of the function's name.
    • End loc will be start loc of the opening paren of params, instead of nothing.

Is there anything you'd like reviewers to focus on?

In edge cases where function and its name are not on the same line this change can produce more warnings in the existing code, based on location of eslint-disable-* comments:

/* eslint array-callback-return: error*/

foo.filter(function 
    bar() {} // eslint-disable-line array-callback-return
)

@mdjermanovic mdjermanovic added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Mar 27, 2020
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 👍 for the change, particularly since this will be landing in a major release.

@kaicataldo
Copy link
Member

Thanks for contributing!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 22, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants