Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: use espree.latestEcmaVersion in config-initializer #13157

Merged
merged 1 commit into from Apr 23, 2020

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Apr 7, 2020

Prerequisites checklist

  • I have read the contributing guidelines.
  • The team has reached consensus on the changes proposed in this pull request. If not, I understand that the evaluation process will begin with this pull request and won't be merged until the team has reached consensus.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Chore

What changes did you make? (Give an overview)

This is a small PR that utilizes espree.latestEcmaVersion in the config initializer so that we don't have to manually update this each time we add a new version to the parser.

Is there anything you'd like reviewers to focus on?

This value will change as soon as we update to a version of Espree with a new supported ecmaVersion. Is that undesirable for any reason? Since the intention is to always use the latest version and since this is intended to only be used once by new users, I don't think this is an issue, but just wanted to check with the rest of the team.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Apr 7, 2020
@kaicataldo kaicataldo added chore This change is not user-facing and removed triage An ESLint team member will look at this issue soon labels Apr 7, 2020
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. There’s a bit of weirdness if more globals are added in an ECMA version that aren’t accounted for, but I don’t think that’s a big enough deal to worry about as its easy for the user to fix.

@kaicataldo kaicataldo merged commit e13256e into master Apr 23, 2020
@kaicataldo kaicataldo deleted the config-init branch April 23, 2020 03:47
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Oct 21, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants