Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Request: Eslint plugins exported via custom entry-point #15069

Closed
1 task done
danieldelcore opened this issue Sep 16, 2021 · 1 comment
Closed
1 task done

Change Request: Eslint plugins exported via custom entry-point #15069

danieldelcore opened this issue Sep 16, 2021 · 1 comment
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint triage An ESLint team member will look at this issue soon
Projects

Comments

@danieldelcore
Copy link

ESLint version

v7.7.0

What problem do you want to solve?

Support the ability to register eslint plugins exposed via custom entry-points.

For example, a package which contains source code for the package itself and all supporting tooling related to the package, including an eslint plugin.

Currently the docs state:

Each plugin is an npm module with a name in the format of eslint-plugin-, such as eslint-plugin-jquery. You can also use scoped packages in the format of @/eslint-plugin- such as @jquery/eslint-plugin-jquery or even @/eslint-plugin such as @jquery/eslint-plugin.

But to support this use case we would need eslint to support the following: @scope/packageName/eslint-plugin-packageName

What do you think is the correct solution?

Eslint could be updated to be entry-point aware when attempting to register plugins.

Potentially by updating this logic (maybe 😬):

const moduleName = naming.normalizePackageName(plugin, "eslint-plugin");

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response

@danieldelcore danieldelcore added core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint triage An ESLint team member will look at this issue soon labels Sep 16, 2021
@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Sep 16, 2021
@nzakas
Copy link
Member

nzakas commented Sep 16, 2021

We aren’t making any changes to how plugins work in the current config system. The new config system doesn’t have any constraints on how your plugins are packaged.

@nzakas nzakas closed this as completed Sep 16, 2021
Triage automation moved this from Needs Triage to Complete Sep 16, 2021
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Mar 16, 2022
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint triage An ESLint team member will look at this issue soon
Projects
Archived in project
Triage
Complete
Development

No branches or pull requests

2 participants