Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new docs site] UI bug with on rules index and details pages #15977

Closed
Tracked by #117
nzakas opened this issue Jun 8, 2022 · 6 comments · Fixed by #16082
Closed
Tracked by #117

[new docs site] UI bug with on rules index and details pages #15977

nzakas opened this issue Jun 8, 2022 · 6 comments · Fixed by #16082
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation
Projects

Comments

@nzakas
Copy link
Member

nzakas commented Jun 8, 2022

For the new documentation site, we have a UI bug when displaying information about recommended/fixable/suggestions on both the rule index page and the rule details pages.

Basically, we can have 0-3 of these showing at any time. When only one is shown, it should take the full width of the page, like this:

Frame 407

This part is actually working correctly. 👍

When two are shown, it should look like this:

Frame 407

And when three are shown, it should look like this:

Frame 407

The rules index page should always show three, but right now it is not styled correctly and is wrapping to two lines:
https://new.eslint.org/docs/rules/

The rules details pages stack the messages one on top of the other (once this PR is merged: #15902)

@nzakas nzakas added bug ESLint is working incorrectly documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Jun 8, 2022
@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Jun 8, 2022
@nzakas nzakas moved this from Needs Triage to Ready to Implement in Triage Jun 8, 2022
@btmills
Copy link
Member

btmills commented Jun 9, 2022

I believe this is working as intended. In sufficiently wide windows (~1300px), I'm seeing the three side by side on https://new.eslint.org/docs/rules/. On narrower windows, it automatically wraps due to the auto-fit and minmax on the grid-template-columns.

Screen Shot 2022-06-08 at 10 21 50 PM

@nzakas
Copy link
Member Author

nzakas commented Jun 9, 2022

Ah gotcha. My screen apparently doesn't go wide enough to see that view.

Then the only outstanding issue is that the background colors and borders are missing.

@mdjermanovic mdjermanovic changed the title Documentation site UI bug with on rules index and details pages [new docs site] UI bug with on rules index and details pages Jun 16, 2022
@DeepshikaS
Copy link
Contributor

I would like to work on this. Border and background color needs to be added right?

  1. Current UI:

image

  1. Expected UI :

image

Basically, It should look like the 2nd Image?

@nzakas
Copy link
Member Author

nzakas commented Jun 18, 2022

Correct. 👍

@DeepshikaS
Copy link
Contributor

Correct. 👍

I'm working on it. Will raise a pr

@nzakas
Copy link
Member Author

nzakas commented Jul 6, 2022

Fixed by #16082

@nzakas nzakas closed this as completed Jul 6, 2022
Triage automation moved this from Ready to Implement to Complete Jul 6, 2022
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jan 3, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation
Projects
Archived in project
Triage
Complete
Development

Successfully merging a pull request may close this issue.

3 participants