New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TryStatement handler property #1930

Closed
btmills opened this Issue Mar 3, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@btmills
Member

btmills commented Mar 3, 2015

TryStatement.handlers became the singular TryStatement.handler in estree/estree#1. no-empty at least uses the plural handlers, which caused babel/babel-eslint#26. Esprima is transitioning gradually by supporting both handlers and handler for a time. Perhaps ESLint should check handler and handlers but deprecate the latter and remove it in v1.0?

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Mar 4, 2015

Member

Yeah, we should update Espree with handler and then start checking both.

Member

nzakas commented Mar 4, 2015

Yeah, we should update Espree with handler and then start checking both.

blazarus pushed a commit to blazarus/eslint that referenced this issue Mar 4, 2015

Brett Lazarus
temporary fix for eslint#1930. There is already a pull request which …
…fixes this, but it hasn't been merged yet.
@emmenko

This comment has been minimized.

Show comment
Hide comment
@emmenko

emmenko Mar 5, 2015

Found the same problem. @btmills thanks for the PR 👍

emmenko commented Mar 5, 2015

Found the same problem. @btmills thanks for the PR 👍

@btmills btmills closed this in 9524c8d Mar 7, 2015

nzakas added a commit that referenced this issue Mar 7, 2015

Merge pull request #1933 from eslint/issue1930
Update: no-empty to check TryStatement.handler (fixes #1930)

@eslint eslint bot locked and limited conversation to collaborators Feb 7, 2018

@eslint eslint bot added the archived due to age label Feb 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.