New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing on current master #1947

Closed
lo1tuma opened this Issue Mar 5, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@lo1tuma
Member

lo1tuma commented Mar 5, 2015

The browser tests are failing on current master. This is because sinon released a new version and we defined in our package.json that we want updates for new minor or patch versions, but we hardcoded the version number of sinon in tests.html.

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Mar 5, 2015

Member

Ugh, I thought I had fixed this a while back.

Member

nzakas commented Mar 5, 2015

Ugh, I thought I had fixed this a while back.

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Mar 5, 2015

Member

Working on this.

Member

nzakas commented Mar 5, 2015

Working on this.

@nzakas nzakas closed this in 29e4476 Mar 5, 2015

nzakas added a commit that referenced this issue Mar 5, 2015

Merge pull request #1948 from eslint/issue1947
Fix: Use unversioned sinon file in browser test (fixes #1947)

@eslint eslint bot locked and limited conversation to collaborators Feb 7, 2018

@eslint eslint bot added the archived due to age label Feb 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.