New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strict rule incorrectly flags module code as not being strict #1956

Closed
nzakas opened this Issue Mar 7, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@nzakas
Member

nzakas commented Mar 7, 2015

When ecmaFeatures.modules is enabled, global strict mode is implied so the strict rule should:

  1. Not flag anything as missing strict mode.
  2. Flag any "use strict" directives as unnecessary.

Working on this.

@nzakas nzakas closed this in 4f6b4d3 Mar 7, 2015

nzakas added a commit that referenced this issue Mar 7, 2015

Merge pull request #1957 from eslint/issue1956
Fix: strict rule should honor module code (fixes #1956)
@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Mar 18, 2015

Thank you for fixing this!

gaearon commented Mar 18, 2015

Thank you for fixing this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.