Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

space-before-function-parentheses false positive on generator methods #2082

Closed
steadicat opened this issue Mar 16, 2015 · 5 comments
Closed
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules

Comments

@steadicat
Copy link

// test.js
class Foo {
  *bar() {
  }
}
// config.json
{
    "ecmaFeatures": {
        "generators": true,
        "classes": true
    },
    "rules": {
        "space-before-function-parentheses": [2, "never"]
    }
}
$ eslint --reset --no-eslintrc --config confing.json test.js

test.js
  2:10  error  Unexpected space before function parentheses  space-before-function-parentheses

This is similar to #1929, but not quite the same.

@btmills btmills added bug ESLint is working incorrectly rule Relates to ESLint's core rules labels Mar 16, 2015
@btmills
Copy link
Member

btmills commented Mar 16, 2015

When the fix for #1929 was implemented, Espree didn't handle generator methods yet, so we should be unblocked on this now.

@btmills
Copy link
Member

btmills commented Mar 16, 2015

Working on this. It'll depend on #2050, so the fix will go into space-before-function-parens.

@nzakas
Copy link
Member

nzakas commented Mar 16, 2015

Any chance to get the change in before #2050? I'd like to do a patch release today or tomorrow and would like to get this fix it.

@btmills
Copy link
Member

btmills commented Mar 16, 2015

Yep, #2083.

@nzakas
Copy link
Member

nzakas commented Mar 16, 2015

You are my hero.

nzakas added a commit that referenced this issue Mar 16, 2015
Fix: space-before-function-parentheses generator methods (fixes #2082)
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

No branches or pull requests

3 participants