Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`spaced-comment` rule warns line-endings of Windows. #3005

Closed
mysticatea opened this issue Jul 15, 2015 · 0 comments

Comments

Projects
None yet
3 participants
@mysticatea
Copy link
Member

commented Jul 15, 2015

This is related with #2884.

On the issue, the problem around CRLF seems to be not fixed completely.
I tried with master branch, this rule still warn at normal block comments.

test.js

/* eslint spaced-comment:2 */

/*
 * test
 */

/**
 * test
 */

Command & Actual

> git log -1
commit e88f8d816072957fcf9c67188ee609f3d40a4957
...
> node .\bin\eslint.js test.js --no-eslintrc

test.js
  3:1  error  Expected space or tab after /* in comment  spaced-comment

✖ 1 problem (1 error, 0 warnings)

Expected

No errors.


To fix, I guess && node.value.indexOf("\r") !== 0 is added into here merely.

@ilyavolodin ilyavolodin added the triage label Jul 15, 2015

@nzakas nzakas added bug rule accepted and removed triage labels Jul 15, 2015

@nzakas nzakas closed this in #3006 Jul 15, 2015

@eslint eslint bot locked and limited conversation to collaborators Feb 7, 2018

@eslint eslint bot added the archived due to age label Feb 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.