Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-unused-vars doco should explicitly mention that relates to the /*global*/ variable #3137

Closed
wbecker opened this issue Jul 23, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@wbecker
Copy link
Contributor

commented Jul 23, 2015

Here it should have an example showing that if you have an unused variable like

/*global sinon */

but then do not use the variable in the comment, this is also picked up by this rule.

@eslintbot

This comment has been minimized.

Copy link

commented Jul 23, 2015

Thanks for the issue! We get a lot of issues, so this message is automatically posted to each one to help you check that you've included all of the information we need to help you.

Reporting a bug? Please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. The source code that caused the problem
  3. The configuration you're using (for the rule or your entire config file)
  4. The actual ESLint output complete with line numbers

Requesting a new rule? Please be sure to include:

  1. The use case for the rule - what is it trying to prevent or flag?
  2. Whether the rule is trying to prevent an error or is purely stylistic
  3. Why you believe this rule is generic enough to be included

Requesting a feature? Please be sure to include:

  1. The problem you want to solve (don't mention the solution)
  2. Your take on the correct solution to problem

Including this information in your issue helps us to triage it and get you a response as quickly as possible.

Thanks!

@wbecker

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2015

This would helped me figure out why I was tripping this rule. I'll try and do this myself...

@nzakas

This comment has been minimized.

Copy link
Member

commented Jul 23, 2015

Good idea.

@wbecker

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2015

Sorry - created a new PR for this because the other one was done via the github editor and got a bit screwey.

@nzakas nzakas closed this in #3144 Jul 23, 2015

nzakas added a commit that referenced this issue Jul 23, 2015

Merge pull request #3144 from wbecker/explain-global-in-no-unused-vars
Docs: Mention variables defined in a global comment (fixes #3137)

@eslint eslint bot locked and limited conversation to collaborators Feb 7, 2018

@eslint eslint bot added the archived due to age label Feb 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.