Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring bower_components by default #3550

Closed
JulianLaval opened this Issue Aug 27, 2015 · 8 comments

Comments

Projects
None yet
5 participants
@JulianLaval
Copy link

JulianLaval commented Aug 27, 2015

ESLint ignores /node_modules by default as per ignored-paths.js. I'm wondering whether it would make sense to ignore /bower_components by default as well given its prominence?

@eslintbot

This comment has been minimized.

Copy link

eslintbot commented Aug 27, 2015

Thanks for the issue! We get a lot of issues, so this message is automatically posted to each one to help you check that you've included all of the information we need to help you.

Reporting a bug? Please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. The source code that caused the problem
  3. The configuration you're using (for the rule or your entire config file)
  4. The actual ESLint output complete with line numbers

Requesting a new rule? Please be sure to include:

  1. The use case for the rule - what is it trying to prevent or flag?
  2. Whether the rule is trying to prevent an error or is purely stylistic
  3. Why you believe this rule is generic enough to be included

Requesting a feature? Please be sure to include:

  1. The problem you want to solve (don't mention the solution)
  2. Your take on the correct solution to problem

Including this information in your issue helps us to triage it and get you a response as quickly as possible.

Thanks!

@eslintbot eslintbot added the triage label Aug 27, 2015

@JulianLaval JulianLaval changed the title Ingnoring bower_components by default Ignoring bower_components by default Aug 27, 2015

@BYK

This comment has been minimized.

Copy link
Member

BYK commented Aug 27, 2015

👍

@BYK BYK added enhancement core question and removed triage labels Aug 27, 2015

@nzakas

This comment has been minimized.

Copy link
Member

nzakas commented Aug 27, 2015

Seems rational

@nzakas nzakas added accepted and removed question labels Aug 27, 2015

@JulianLaval

This comment has been minimized.

Copy link
Author

JulianLaval commented Aug 27, 2015

Cool stuff. ignored-paths.js and docs need to be updated; any relevant unit tests?

@nzakas nzakas added the breaking label Aug 31, 2015

@nzakas nzakas added this to the v2.0.0 milestone Aug 31, 2015

@nzakas nzakas referenced this issue Aug 31, 2015

Closed

Roadmap: 2.0.0 #3561

11 of 11 tasks complete
@gronke

This comment has been minimized.

Copy link
Contributor

gronke commented Oct 1, 2015

@JulianLaval could you please do a rebase against master? I'd like to merge your commit on top of https://github.com/gronke/eslint/tree/issue-2365 as @nzakas suggested in #3948

gronke added a commit to gronke/eslint that referenced this issue Oct 1, 2015

@JulianLaval

This comment has been minimized.

Copy link
Author

JulianLaval commented Oct 2, 2015

Rebasing off of upstream yields the following error. Have I missed something?

 1) CLIEngine executeOnFiles() Fix Mode should return fixed text on multiple files when in fix mode:

  AssertionError: expected { Object (results, errorCount, ...) } to deeply equal { Object (results, errorCount, ...) }
  + expected - actual

       {
         "errorCount": 0
         "filePath": "...\AppData\\Local\\Temp\\eslint\\fixtures\\fixmode\\quotes-semi-eqeqeq.js"
         "messages": []
  -      "output": "var msg = \"hi\";\r\nif (msg === \"hi\") {\r\n\r\n}\r\n"
  +      "output": "var msg = \"hi\";\nif (msg === \"hi\") {\n\n}\n"
         "warningCount": 0
       }
       {
         "errorCount": 1
             "severity": 2
             "source": "var msg = 'hi' + foo;"
           }
         ]
  -      "output": "var msg = \"hi\" + foo;\r\n"
  +      "output": "var msg = \"hi\" + foo;\n"
         "warningCount": 0
       }
     ]
     "warningCount": 0

  at Context.<anonymous> (eslint\tests\lib\cli-engine.js:752:24)

gronke added a commit to gronke/eslint that referenced this issue Oct 2, 2015

@gronke

This comment has been minimized.

Copy link
Contributor

gronke commented Oct 2, 2015

Rebasing https://github.com/gronke/eslint/tree/issue-2365 against upstream/master worked without that issue. To be honest I just re-applied your diff-patch to that branch by hand 😋

@JulianLaval thanks for agreeing to include your changes in #3948

@JulianLaval

This comment has been minimized.

Copy link
Author

JulianLaval commented Oct 2, 2015

Ha no worries, will leave this alone in that case!

gronke added a commit to gronke/eslint that referenced this issue Oct 4, 2015

gronke added a commit to gronke/eslint that referenced this issue Oct 4, 2015

gronke added a commit to gronke/eslint that referenced this issue Oct 4, 2015

gronke added a commit to gronke/eslint that referenced this issue Oct 4, 2015

gronke added a commit to gronke/eslint that referenced this issue Oct 4, 2015

gronke added a commit to gronke/eslint that referenced this issue Oct 4, 2015

gronke added a commit to gronke/eslint that referenced this issue Oct 4, 2015

gronke added a commit to gronke/eslint that referenced this issue Oct 4, 2015

gronke added a commit to gronke/eslint that referenced this issue Oct 4, 2015

gronke added a commit to gronke/eslint that referenced this issue Oct 8, 2015

gronke added a commit to gronke/eslint that referenced this issue Oct 8, 2015

gronke added a commit to gronke/eslint that referenced this issue Nov 13, 2015

gronke added a commit to gronke/eslint that referenced this issue Nov 13, 2015

gronke added a commit to gronke/eslint that referenced this issue Nov 19, 2015

gronke added a commit to gronke/eslint that referenced this issue Nov 21, 2015

gronke added a commit to gronke/eslint that referenced this issue Dec 1, 2015

gronke added a commit to gronke/eslint that referenced this issue Dec 2, 2015

@nzakas nzakas closed this in 0e9f1ae Dec 2, 2015

nzakas added a commit that referenced this issue Dec 2, 2015

Merge pull request #4592 from JulianLaval/issue3550
Breaking: added bower_components to default ignore (fixes #3550)

@eslint eslint bot locked and limited conversation to collaborators Feb 7, 2018

@eslint eslint bot added the archived due to age label Feb 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.