New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`quote-props` rule false positive on computed properties. #3557

Closed
mysticatea opened this Issue Aug 28, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@mysticatea
Member

mysticatea commented Aug 28, 2015

Spawned from #3544.

This rule should ignore computed properties.

/* eslint-env es6 */
/* eslint quote-props: [2, "always"] */
var x;
var obj = ({
    [x]: 0
});

Actual:

> eslint -v
v1.2.1
> eslint test.js --no-eslintrc

test.js
  5:5  error  Unquoted property `x` found  quote-props

✖ 1 problems (2 errors, 0 warnings)

Expected:

no errors.

@BYK BYK self-assigned this Aug 28, 2015

@BYK

This comment has been minimized.

Member

BYK commented Aug 28, 2015

Looking into this.

@mysticatea

This comment has been minimized.

Member

mysticatea commented Aug 28, 2015

Thank you!

BYK added a commit that referenced this issue Aug 28, 2015

BYK added a commit that referenced this issue Aug 28, 2015

BYK added a commit that referenced this issue Aug 28, 2015

@eslint eslint bot locked and limited conversation to collaborators Feb 7, 2018

@eslint eslint bot added the archived due to age label Feb 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.