Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jsx-quotes fixable #4377

Closed
ianks opened this Issue Nov 10, 2015 · 3 comments

Comments

Projects
None yet
4 participants
@ianks
Copy link

ianks commented Nov 10, 2015

How do you guys feel about making jsx-quotes fixable? It is a fairly trivial fix, and we already fix regular quotes, so it is a trivial extension to that. I have a PR which implements this (#4374) if you would like to see what the implementation looks like.

@eslintbot

This comment has been minimized.

Copy link

eslintbot commented Nov 10, 2015

Thanks for the issue! If you're reporting a bug, please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. What you did (the source code and ESLint configuration)
  3. The actual ESLint output complete with numbers
  4. What you expected to happen instead

Requesting a new rule? Please see Proposing a New Rule for instructions.

@eslintbot eslintbot added the triage label Nov 10, 2015

@nzakas nzakas added accepted and removed evaluating labels Nov 11, 2015

@nzakas

This comment has been minimized.

Copy link
Member

nzakas commented Nov 11, 2015

Sounds good

gabro added a commit to gabro/eslint that referenced this issue Jan 15, 2016

@gyandeeps

This comment has been minimized.

Copy link
Member

gyandeeps commented Jan 15, 2016

Closing this manually as the PR had refs and not fixes.

@gyandeeps gyandeeps closed this Jan 15, 2016

@eslint eslint bot locked and limited conversation to collaborators Feb 7, 2018

@eslint eslint bot added the archived due to age label Feb 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.