Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we dogfood no-underscore-dangle's "allowAfterThis" option? #4599

Closed
platinumazure opened this Issue Dec 3, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@platinumazure
Copy link
Member

platinumazure commented Dec 3, 2015

Now that #4562 is in, I know at least one case (cli-engine.js, _fileCache) of // eslint-disable-line which could be removed by changing our ESLint config, if desired.

Basically, this is suggesting that we consume { allowAfterThis: true } in .eslintrc, and remove eslint-disable and eslint-disable-line comments that no longer need to exist.

Version: master
Not reporting a real bug per se, so not answering the rest of the questions 😄

@eslintbot

This comment has been minimized.

Copy link

eslintbot commented Dec 3, 2015

@platinumazure Thanks for the issue! If you're reporting a bug, please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. What you did (the source code and ESLint configuration)
  3. The actual ESLint output complete with numbers
  4. What you expected to happen instead

Requesting a new rule? Please see Proposing a New Rule for instructions.

@eslintbot eslintbot added the triage label Dec 3, 2015

@nzakas nzakas added enhancement build accepted and removed triage labels Dec 4, 2015

@nzakas

This comment has been minimized.

Copy link
Member

nzakas commented Dec 4, 2015

Yeah, I'm all for dogfooding rules.

@platinumazure

This comment has been minimized.

Copy link
Member Author

platinumazure commented Dec 4, 2015

Working on this.

@nzakas nzakas closed this in e6e33a4 Dec 4, 2015

nzakas added a commit that referenced this issue Dec 4, 2015

Merge pull request #4604 from platinumazure/dogfood-no-underscore-dangle
Build: Consume no-underscore-dangle allowAfterThis option (fixes #4599)

@eslint eslint bot locked and limited conversation to collaborators Feb 7, 2018

@eslint eslint bot added the archived due to age label Feb 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.