Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path Analysis output makes debug mode hard to read #4631

Closed
ilyavolodin opened this Issue Dec 8, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@ilyavolodin
Copy link
Member

ilyavolodin commented Dec 8, 2015

Path Analysis is adding a tone of output for every code path to the debug log. On Windows machine the amount of buffer is limited, mine is set to 1000 lines and linting just one file (Makefile.js from our repository) overflows the buffer and doesn't let me see the information in the begging of the output. Path Analysis output should probably be piped into a different log.

@nzakas

This comment has been minimized.

Copy link
Member

nzakas commented Dec 8, 2015

Any proposal for how that should work? How would we get debug info for code path analysis?

Is it possible to just reduce the debug messages rather than trying to filter?

@ilyavolodin

This comment has been minimized.

Copy link
Member Author

ilyavolodin commented Dec 8, 2015

I'm not really all that familiar with the debug and what could be done with it. As far as I understand it, we name debug log for each file. What I was thinking was to name Path Analysis debug log something completely different from the rest of the ESLint, that way if somebody wants debug log specifically for Path Analysis, they can run DEBUG=eslint:code-analysis to get it. Not really 100% sure how to implement it properly, but we added --debug flag to be able to ask users to look through the logs, and logs for Path Analysis will be unlikely candidate for resolving issue.

@nzakas

This comment has been minimized.

Copy link
Member

nzakas commented Dec 8, 2015

Which is why I ask, can we just reduce the amount of debug messages it creates?

Trying to filter is going to be a big pain, but if the debug messages aren't that useful, we should eliminate some.

@mysticatea

This comment has been minimized.

Copy link
Member

mysticatea commented Dec 8, 2015

Oh, sorry for this.
I think I can remove those debug messages except DOT outputs.

@nzakas nzakas added accepted and removed evaluating labels Dec 8, 2015

nzakas added a commit that referenced this issue Dec 19, 2015

Merge pull request #4726 from eslint/issue-4631
Fix: Remove path analysis from debug log (fixes #4631)

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.