Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property ruleId not null to the lintings fatal. #4722

Closed
regseb opened this Issue Dec 16, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@regseb
Copy link
Contributor

commented Dec 16, 2015

Hi,

When verify() method return a linting fatal : the message doesn't contain the property ruleId. But in documentation, it's written that the property ruleId is null when the message is fatal: "ruleId - the ID of the rule that triggered the messages (or null if fatal is true)."

@eslintbot

This comment has been minimized.

Copy link

commented Dec 16, 2015

@regseb Thanks for the issue! If you're reporting a bug, please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. What you did (the source code and ESLint configuration)
  3. The actual ESLint output complete with numbers
  4. What you expected to happen instead

Requesting a new rule? Please see Proposing a New Rule for instructions.

@eslintbot eslintbot added the triage label Dec 16, 2015

@nzakas nzakas added bug core accepted and removed triage labels Dec 17, 2015

@nzakas

This comment has been minimized.

Copy link
Member

commented Dec 17, 2015

Oops, definitely an oversight.

@nzakas nzakas closed this in c5b35cc Dec 17, 2015

nzakas added a commit that referenced this issue Dec 17, 2015

Merge pull request #4723 from regseb/issue4722
Fix: Set null to property ruleId when fatal is true (fixes #4722)

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.