Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty schemas allow any options #4789

Closed
btmills opened this Issue Dec 22, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@btmills
Copy link
Member

commented Dec 22, 2015

Originally discovered by @gyandeeps in #4786 (comment).

module.exports.schema = [];

Right now, the above schema will allow any number and kind of options after the severity, when it should only allow a severity.

Working on this.

btmills added a commit that referenced this issue Dec 22, 2015

Fix: Empty schemas forbid any options (fixes #4789)
Previously, an empty schema `[]` would allow any number and type of
options after the severity. It will now warn if options are passed to
rules that don't accept options.

@btmills btmills closed this in 742f73d Dec 22, 2015

ilyavolodin added a commit that referenced this issue Dec 22, 2015

Merge pull request #4790 from eslint/issue4789
Fix: Empty schemas forbid any options (fixes #4789)

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.