Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`consistent-this` has no default alias #4833

Closed
IanVS opened this Issue Dec 31, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@IanVS
Copy link
Member

commented Dec 31, 2015

As a part of #4809, I am checking that rules have default configurations, and found that consistent-this does not. In eslint:recommended, we use "that", but in the rule's docs the examples have "self". I suggest setting the default to "that", in order to cause the least disruption for anyone who may have been relying on the default behavior from our recommended rules.

@nzakas nzakas added accepted and removed evaluating labels Jan 6, 2016

@alberto alberto closed this in 1569695 Jan 7, 2016

gyandeeps added a commit that referenced this issue Jan 7, 2016

Merge pull request #4868 from eslint/issue4833
Update: Adds default 'that' for consistent-this (fixes #4833)

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.