Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`func-style` has no default #4834

Closed
IanVS opened this Issue Dec 31, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@IanVS
Copy link
Member

commented Dec 31, 2015

As part of #4809, I'm checking that we have sane defaults in our rules. func-style has no default.

In eslint:recommended, we use [0, "declaration"]. Any objections to making this the official default?

@alberto

This comment has been minimized.

Copy link
Member

commented Jan 6, 2016

Current default is expression. Should we change it?

@IanVS

This comment has been minimized.

Copy link
Member Author

commented Jan 7, 2016

Ah, I didn't look close enough. It looks at first glance from

var style = context.options[0],
that there is no default, but it's handled a few lines down. I'll make a PR for the docs.

@IanVS IanVS added documentation and removed enhancement labels Jan 7, 2016

IanVS added a commit that referenced this issue Jan 7, 2016

@IanVS IanVS closed this in 0b3c01e Jan 7, 2016

gyandeeps added a commit that referenced this issue Jan 7, 2016

Merge pull request #4870 from eslint/issue4834
Docs: Specify default for func-style (fixes #4834)

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.