Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule valid-jsdoc fails with "Missing or invalid tag name" for name expression after @this #4854

Closed
tschaub opened this Issue Jan 4, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@tschaub
Copy link
Contributor

tschaub commented Jan 4, 2016

With a comment like the one below, the valid-jsdoc rule (as of 1c87a9b) is violated with "Missing or invalid tag name."

/**
 * @this {Widget}
 */

Instead, I would expect the rule to pass (this is a valid annotation by the Closure Compiler syntax for @this).

This is ticketed as eslint/doctrine#143.

I'm opening the issue here to see if there would be support for updating the doctrine dependency prior to the 2.0 release.

@eslintbot

This comment has been minimized.

Copy link

eslintbot commented Jan 4, 2016

@tschaub Thanks for the issue! If you're reporting a bug, please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. What you did (the source code and ESLint configuration)
  3. The actual ESLint output complete with numbers
  4. What you expected to happen instead

Requesting a new rule? Please see Proposing a New Rule for instructions.

@eslintbot eslintbot added the triage label Jan 4, 2016

@nzakas nzakas added bug core accepted blocked and removed triage labels Jan 4, 2016

@nzakas

This comment has been minimized.

Copy link
Member

nzakas commented Jan 4, 2016

Yeah, we can do that.

@nzakas nzakas removed the blocked label Jan 6, 2016

@nzakas

This comment has been minimized.

Copy link
Member

nzakas commented Jan 6, 2016

Doctrine has been updated. If you'd like to submit a PR, we can upgrade it. (Be sure the commit message begins with "Upgrade:").

@nzakas nzakas closed this in 7c97201 Jan 7, 2016

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.