Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line numbers and broken rule for each message are invisible on Solarized Dark theme #4886

Closed
leighman opened this Issue Jan 8, 2016 · 3 comments

Comments

Projects
None yet
5 participants
@leighman
Copy link
Contributor

leighman commented Jan 8, 2016

What version are you using?

v1.10.3

What did you do?

Tried to use eslint from terminal

What happened?

Line numbers and broken rule were invisible

What did you expect to happen?

To be able to see them.

==

Turns out this is a long-standing bug in solarized [1] with no easy fix. Chalk author suggests using 'dim' rather than 'gray' [2] which looks just as beautiful to me.

[1] altercation/solarized#220
[2] chalk/chalk#40

@eslintbot

This comment has been minimized.

Copy link

eslintbot commented Jan 8, 2016

@leighman Thanks for the issue! If you're reporting a bug, please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. What you did (the source code and ESLint configuration)
  3. The actual ESLint output complete with numbers
  4. What you expected to happen instead

Requesting a new rule? Please see Proposing a New Rule for instructions.

@eslintbot eslintbot added the triage label Jan 8, 2016

@ilyavolodin ilyavolodin added bug core evaluating and removed triage labels Jan 8, 2016

@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Jan 8, 2016

I don't understand. Is this an issue with stylish output and similar, where the control characters for changing color work poorly on certain terminal themes?

@nzakas nzakas added accepted and removed evaluating labels Jan 8, 2016

@leighman

This comment has been minimized.

Copy link
Contributor Author

leighman commented Jan 8, 2016

Yes, a bad combination of chalk.gray and solarized background colour
solarized-before

@nzakas nzakas closed this in a1840e7 Jan 8, 2016

nzakas added a commit that referenced this issue Jan 8, 2016

Merge pull request #4885 from leighman/master
Fix: gray text was invisible on Solarized Dark theme (fixes #4886)

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.