Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures #4888

Closed
nzakas opened this Issue Jan 8, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@nzakas
Copy link
Member

commented Jan 8, 2016

In preparing to do the release, I found a large number of test failures. This appears to be related to the ignore file changes (#3948). The full log is at https://gist.github.com/nzakas/4ef85b9c8b0de95e4976. There's 81 failures in total that need to be resolved before we can do a release.

@alberto

This comment has been minimized.

Copy link
Member

commented Jan 8, 2016

Do they fail by running npm test? They are all green on my machine. Did you remember to npm install? That bites me from time to time.

@gyandeeps

This comment has been minimized.

Copy link
Member

commented Jan 8, 2016

Its happening on windows machines and it due to this: https://github.com/eslint/eslint/blob/master/lib/cli-engine.js#L556

@alberto

This comment has been minimized.

Copy link
Member

commented Jan 8, 2016

Just read on gitter it may be a windows-only issue. That explains why it wasn't caught by CI. I'm running on OSX.

@gyandeeps gyandeeps closed this in 7c9be60 Jan 8, 2016

nzakas added a commit that referenced this issue Jan 8, 2016

Merge pull request #4890 from eslint/issue4888
Fix: Fix path errors in windows (fixes #4888)

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.