Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppVeyor #4894

Closed
gyandeeps opened this Issue Jan 9, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@gyandeeps
Copy link
Member

gyandeeps commented Jan 9, 2016

Second shot at adding AppVeyor to eslint project.
Based on the observation so far these are some of the things which are very annoying about
AppVeyor vs Travis:

  • Its sequential ie it will run one build at one time.
    • One build means running on node 4 is one build so if we have more node version then that many build per PR.
  • Its very slow as it takes around of 30 mins for 1 PR which include 3 builds.
  • If you want to restart the build then you have to restart the whole build for the PR and not just for a particular version of node build.

Proposal:

  • We should setup build for just PR and not branches (except for master branch)
  • We should only run build on NodeJs 4.x for now.
    • We have see a quick response then we can keep adding more node versions in the future.
  • Increase mocha timeout to 10000 from 4000 for AppVeyor as its very slow.
@rpatil26

This comment has been minimized.

Copy link
Contributor

rpatil26 commented Jan 9, 2016

@gyandeeps So AppVeyor is sequential by design or because of our configuration?

Given that it's also slow, is it still worth adding?

@nzakas

This comment has been minimized.

Copy link
Member

nzakas commented Jan 9, 2016

Sounds like a good approach. We really just need a Windows spot check for path/line ending differences, so just one Node environment should be enough.

@nzakas nzakas added accepted and removed evaluating labels Jan 9, 2016

@ilyavolodin

This comment has been minimized.

Copy link
Member

ilyavolodin commented Jan 9, 2016

@rpatil26 AppVeyor is not sequential, it's just for free OSS plan it only supports one single simultaneous build. Problem is, we've had our share of issues that are only happen in Windows environment, and while most of the ESLint team is using Windows, a lot of PRs are coming from people using OSX/Linux, so we need a way to verify anything that deals with file system.

@gyandeeps gyandeeps closed this in 3906481 Jan 9, 2016

gyandeeps added a commit that referenced this issue Jan 9, 2016

Merge pull request #4898 from eslint/issue4894
Build: Add AppVeyor CI (fixes #4894)
@rpatil26

This comment has been minimized.

Copy link
Contributor

rpatil26 commented Jan 10, 2016

Thank you @ilyavolodin for the informative details. I jumped in without the context. 😄

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.