New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change messaging in brace-style rule #490

Closed
michaelficarra opened this Issue Jan 3, 2014 · 5 comments

Comments

Projects
None yet
3 participants
@michaelficarra
Member

michaelficarra commented Jan 3, 2014

Currently, errors say

Opening curly brace does not appear on the same line as the block identifier.

while that isn't really why the rule was triggered. See #482.

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Jan 3, 2014

Member

"Opening curly brace does not appear on the same line as the block identifier condition."?

Member

nzakas commented Jan 3, 2014

"Opening curly brace does not appear on the same line as the block identifier condition."?

@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Jan 3, 2014

Member

No, it's not always a condition. For switch, it's a discriminant; for with, it's a target; for functions, it's a parameter list. Maybe something simple along the lines of "brace style violated"?

Member

michaelficarra commented Jan 3, 2014

No, it's not always a condition. For switch, it's a discriminant; for with, it's a target; for functions, it's a parameter list. Maybe something simple along the lines of "brace style violated"?

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Jan 3, 2014

Member

I'd rather the message be explicit.

Member

nzakas commented Jan 3, 2014

I'd rather the message be explicit.

@ilyavolodin

This comment has been minimized.

Show comment
Hide comment
@ilyavolodin

ilyavolodin Jan 3, 2014

Member

How about something like "Openning curly brace does not appear on the same line as controlling statement". Controlling statement includes conditions, parameters, etc.

Member

ilyavolodin commented Jan 3, 2014

How about something like "Openning curly brace does not appear on the same line as controlling statement". Controlling statement includes conditions, parameters, etc.

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Jan 18, 2014

Member

I'm good with that for now.

Member

nzakas commented Jan 18, 2014

I'm good with that for now.

@nzakas nzakas closed this in 6478b85 Jan 18, 2014

@eslint eslint bot locked and limited conversation to collaborators Feb 7, 2018

@eslint eslint bot added the archived due to age label Feb 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.