Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default rule configuration for plugins #4952

Closed
nzakas opened this Issue Jan 14, 2016 · 8 comments

Comments

Projects
None yet
5 participants
@nzakas
Copy link
Member

nzakas commented Jan 14, 2016

In updating plugins to support environments, I found that we're still supporting rulesConfig in plugins. I thought we had removed this feature in 1.0.0, but apparently not.

In carrying through the spirit of not forcing anything on anyone, I think it would be best to remove rulesConfig support and replace it with named configurations in plugins (#3659). That way, a plugin can still export rule configuration, but instead of forcing it on users, users can opt-in (just as they do with eslint:recommended).

Thoughts?

@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Jan 14, 2016

Just to make sure I have this right:

  • Exporting rulesConfig in plugins will be discouraged (possibly deprecated);
  • Said export will be ignored by ESLint; and
  • Plugin developers are encouraged to create ESLint configuration packages (eslint-config-*) to represent one or more recommended configurations?

If I'm understanding correctly, I'm 👍.

@nzakas

This comment has been minimized.

Copy link
Member Author

nzakas commented Jan 14, 2016

All except the last one. #3659 lets you define configs directly in the plugin rather than having a separate package.

@mysticatea

This comment has been minimized.

Copy link
Member

mysticatea commented Jan 14, 2016

👍

@ilyavolodin

This comment has been minimized.

Copy link
Member

ilyavolodin commented Jan 14, 2016

I think that's reasonable if we provide another way of configuring plugins (like mentioned above ability to create configs within plugins).

@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Jan 14, 2016

@nzakas Thanks, I wasn't aware of that and will check it out.

@captbaritone

This comment has been minimized.

Copy link
Contributor

captbaritone commented Jan 14, 2016

👍 We were recently frustrated by the disparity between the core rules being off by default, and plugins still having rules that were on by default.

cc @afahim

@platinumazure

This comment has been minimized.

Copy link
Member

platinumazure commented Jan 14, 2016

@nzakas Looks like the issue you mentioned is still open with no real indication of progress (including but not limited to a PR). Is that something you're hoping to get in for 2.0.0? I'm not sure it's a good idea to remove this functionality in 2.0.0 without having a replacement available, or is this targeted for 3.0?

@nzakas

This comment has been minimized.

Copy link
Member Author

nzakas commented Jan 14, 2016

We will do both for 2.0.0. I already have this removed.

@nzakas nzakas self-assigned this Jan 14, 2016

nzakas added a commit that referenced this issue Jan 14, 2016

nzakas added a commit that referenced this issue Jan 14, 2016

@nzakas nzakas added this to the v2.0.0 milestone Jan 14, 2016

nzakas added a commit that referenced this issue Jan 15, 2016

nzakas added a commit that referenced this issue Jan 15, 2016

nzakas added a commit that referenced this issue Jan 15, 2016

@nzakas nzakas closed this in b28a19d Jan 19, 2016

nzakas added a commit that referenced this issue Jan 19, 2016

Merge pull request #4955 from eslint/issue4782
Breaking: Plugins envs and config removal (fixes #4782, fixes #4952)

gabro added a commit to buildo/eslint-plugin-no-loops that referenced this issue Mar 16, 2016

Remove default rule configuration
It's not supported anymore in eslint >= 2.0 as per
eslint/eslint#4952

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.