Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Rules should get `sourceType` from Program node, not from `context.parserOptions` #4960

Closed
nre opened this Issue Jan 15, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@nre
Copy link
Contributor

commented Jan 15, 2016

@nzakas says:

should check the program node for sourceType, as not all parsers will support parsing as a module using parser options.

Rules to update:

  • no-eval
  • no-invalid-this
  • no-redeclare
  • no-use-before-define
  • strict (updated in #4948)

and 'migrating-to-2.0.0.md'.

@eslintbot

This comment has been minimized.

Copy link

commented Jan 15, 2016

@nre Thanks for the issue! If you're reporting a bug, please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. What you did (the source code and ESLint configuration)
  3. The actual ESLint output complete with numbers
  4. What you expected to happen instead

Requesting a new rule? Please see Proposing a New Rule for instructions.

@eslintbot eslintbot added the triage label Jan 15, 2016

@nzakas nzakas closed this in da3336c Jan 16, 2016

nzakas added a commit that referenced this issue Jan 16, 2016

Merge pull request #4962 from nre/issue4960
Update: Rules should get `sourceType` from Program node (fixes #4960)

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.