Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parsing of quoted generator methods #4981

Closed
sosz opened this Issue Jan 17, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@sosz
Copy link

sosz commented Jan 17, 2016

Example:

class A {
    *'foo'() {}
    *'bar'() {} // ESLint: Duplicate name "undefined". (no-dupe-class-members)
}

So basically, undefined is assigned as the name of quoted generator methods inside a class.

Reported by eslint@1.10.3.

@eslintbot

This comment has been minimized.

Copy link

eslintbot commented Jan 17, 2016

@hagaiak Thanks for the issue! If you're reporting a bug, please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. What you did (the source code and ESLint configuration)
  3. The actual ESLint output complete with numbers
  4. What you expected to happen instead

Requesting a new rule? Please see Proposing a New Rule for instructions.

@eslintbot eslintbot added the triage label Jan 17, 2016

@mysticatea mysticatea added bug rule accepted and removed triage labels Jan 17, 2016

@mysticatea mysticatea self-assigned this Jan 17, 2016

@mysticatea

This comment has been minimized.

Copy link
Member

mysticatea commented Jan 17, 2016

Thank you for this issue.

Oh sorry. I confirmed it on the online demo.
I will fix it

mysticatea added a commit to mysticatea/eslint that referenced this issue Jan 17, 2016

@nzakas nzakas closed this in #4982 Jan 17, 2016

nzakas added a commit that referenced this issue Jan 17, 2016

Merge pull request #4982 from mysticatea/no-dupe-class-members/fix-st…
…ring-literal-name

Fix: `no-dupe-class-members` false positive (fixes #4981)

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.