Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated rules and update documentation #5032

Closed
ilyavolodin opened this issue Jan 22, 2016 · 8 comments

Comments

Projects
None yet
4 participants
@ilyavolodin
Copy link
Member

commented Jan 22, 2016

Before we release 2.0 we should remove any deprecated rules that are still around. The only two rules I found are:

  • space-before-keywords - replaced by keyword-spacing
  • space-after-keywords - replaced by keyword-spacing
  • no-arrow-condition - replaced by no-confusing-arrow, no-constant-condition
  • space-return-throw-case - replaced by keyword-spacing

We should also updated documentation to reflect removed rules. For example, I just noticed that we removed space-before-keywords and space-after-keywords, but they do not show up under Removed rules in http://eslint.org/docs/rules/

@ilyavolodin ilyavolodin added this to the v2.0.0 milestone Jan 22, 2016

@gyandeeps

This comment has been minimized.

Copy link
Member

commented Jan 22, 2016

And space-return-throw-case also.

@mysticatea

This comment has been minimized.

Copy link
Member

commented Jan 22, 2016

And no-arrow-condition was replaced by no-constant-condition and no-confusing-arrow.
http://eslint.org/docs/2.0.0/user-guide/migrating-to-2.0.0#removed-rules

@gyandeeps gyandeeps self-assigned this Jan 28, 2016

@nzakas nzakas closed this in 519f39f Jan 28, 2016

nzakas added a commit that referenced this issue Jan 28, 2016

Merge pull request #5089 from eslint/issue5032
Breaking: Remove deprecated rules (fixes #5032)

@ilyavolodin ilyavolodin reopened this Jan 28, 2016

@ilyavolodin

This comment has been minimized.

Copy link
Member Author

commented Jan 28, 2016

This issue is not complete. Deprecated rules should be noted in replacements.json file and readme.md should be updated to reflect that the rules have been removed.

@ilyavolodin

This comment has been minimized.

Copy link
Member Author

commented Jan 28, 2016

Also each .md files for removed rules should be updated with replacement notice.

@gyandeeps

This comment has been minimized.

Copy link
Member

commented Jan 28, 2016

Its already noted in https://github.com/eslint/eslint/blob/master/conf/replacements.json

Yup, forgot to update .md files. Should we just remove .md files?

@nzakas

This comment has been minimized.

Copy link
Member

commented Jan 28, 2016

No, we keep the documentation for old rules so search engine results don't break.

@gyandeeps

This comment has been minimized.

Copy link
Member

commented Jan 28, 2016

Just checked all of the rule's .md file has the replacement notice also.

What is missing?

@ilyavolodin

This comment has been minimized.

Copy link
Member Author

commented Jan 28, 2016

Oh, in that case, nevermind. I didn't see those changes in your PR, so that's why I assumed that it wasn't made.

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.