New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-cond-assign incorrectly flagging pattern #505

Closed
nzakas opened this Issue Jan 13, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@nzakas
Member

nzakas commented Jan 13, 2014

The no-cond-assign rule is incorrect flagging this pattern:

if ((foo = bar)) {
    // ...
}

The double parens are an indicator of the intent to assign (per JSLint) and should not cause a warning.

@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Jan 13, 2014

Member

Working on this.

Member

michaelficarra commented Jan 13, 2014

Working on this.

michaelficarra added a commit to michaelficarra/eslint that referenced this issue Jan 13, 2014

@nzakas nzakas closed this in #506 Jan 13, 2014

nzakas added a commit that referenced this issue Jan 13, 2014

Merge pull request #506 from michaelficarra/GH-505
fixes #505: no-cond-assign should ignore doubly parenthesised tests

@eslint eslint bot locked and limited conversation to collaborators Feb 7, 2018

@eslint eslint bot added the archived due to age label Feb 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.