Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Configuring ESLint" reference to "default rules" #5100

Closed
jmm opened this issue Jan 29, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@jmm
Copy link
Contributor

commented Jan 29, 2016

Configuring ESLint says::

All rules that are enabled by default are set to 2

While according to Rules:

All rules are disabled by default.

It seems that perhaps Configuring is referring to eslint:recommended. If that's the case, then since that's not mentioned anywhere else in the document I think it would make sense to just transfer that section to the top of Rules. In any case, the 2 documents should be consistent.

@eslintbot

This comment has been minimized.

Copy link

commented Jan 29, 2016

@jmm Thanks for the issue! If you're reporting a bug, please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. What you did (the source code and ESLint configuration)
  3. The actual ESLint output complete with numbers
  4. What you expected to happen instead

Requesting a new rule? Please see Proposing a New Rule for instructions.

@ilyavolodin

This comment has been minimized.

Copy link
Member

commented Jan 29, 2016

I think that's a leftover from before 1.0.0 release, where we actually had defaults. Was probably just overlooked, but should be fixed anyways.

@jmm

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2016

Thanks @ilyavolodin!

@btmills

This comment has been minimized.

Copy link
Member

commented Jan 30, 2016

Working on this.

@btmills btmills self-assigned this Jan 30, 2016

btmills added a commit that referenced this issue Jan 30, 2016

Docs: Remove reference to rules enabled by default (fixes #5100)
The entire line can be safely removed because the effects on exit code
are already discussed at the top of the section.

@gyandeeps gyandeeps closed this in 757651e Jan 31, 2016

gyandeeps added a commit that referenced this issue Jan 31, 2016

Merge pull request #5110 from eslint/issue5100
Docs: Remove reference to rules enabled by default (fixes #5100)
@jmm

This comment has been minimized.

Copy link
Contributor Author

commented Feb 8, 2016

Thanks all! Is it worth moving that information to the top of the Rules page where eslint:recommended is discussed?

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.