Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`no-empty` rule description on index page is inaccurate #5105

Closed
jmm opened this Issue Jan 30, 2016 · 5 comments

Comments

Projects
None yet
5 participants
@jmm
Copy link
Contributor

jmm commented Jan 30, 2016

On the Rules index no-empty is described as:

disallow empty statements

It should be:

disallow empty block statements

I'm surprised it's not actually called no-empty-block, but that's another story (though you could change it for v2).

@eslintbot

This comment has been minimized.

Copy link

eslintbot commented Jan 30, 2016

@jmm Thanks for the issue! If you're reporting a bug, please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. What you did (the source code and ESLint configuration)
  3. The actual ESLint output complete with numbers
  4. What you expected to happen instead

Requesting a new rule? Please see Proposing a New Rule for instructions.

@ilyavolodin

This comment has been minimized.

Copy link
Member

ilyavolodin commented Jan 30, 2016

Agree. Although there is no such think in JS as empty statement in general.

@jmm

This comment has been minimized.

@michaelficarra

This comment has been minimized.

Copy link
Member

michaelficarra commented Jan 30, 2016

Hahaha this project is hilarious sometimes. @jmm to add additional confusion, there's also a rule that reports empty statements in the stylistic issues section called no-extra-semi. Both of these need to be renamed very badly.

@nzakas

This comment has been minimized.

Copy link
Member

nzakas commented Feb 2, 2016

no-empty started out as a direct port of the JSHint rule of the same name. It's too late to change the rule name, but we can definitely fix the docs.

@nzakas nzakas closed this in 74360d6 Feb 5, 2016

nzakas added a commit that referenced this issue Feb 5, 2016

Merge pull request #5154 from eslint/issue5105
Docs: Note no-empty applies to empty block statements (fixes #5105)

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.