New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stylish output as default #517

Closed
nzakas opened this Issue Jan 15, 2014 · 6 comments

Comments

Projects
None yet
3 participants
@nzakas
Member

nzakas commented Jan 15, 2014

The request has been made to switch to use @sindresorhus' stylish formatter as the default for ESLint. Assuming he has no objections, we should do it.

https://github.com/sindresorhus/eslint-stylish

@sindresorhus

This comment has been minimized.

Show comment
Hide comment
@sindresorhus

sindresorhus Jan 15, 2014

Contributor

👍

Contributor

sindresorhus commented Jan 15, 2014

👍

@sindresorhus

This comment has been minimized.

Show comment
Hide comment
@sindresorhus

sindresorhus Jan 15, 2014

Contributor

I still feel the various reporter should be separate node modules though and the default ones just dependencies of ESLint.

Contributor

sindresorhus commented Jan 15, 2014

I still feel the various reporter should be separate node modules though and the default ones just dependencies of ESLint.

@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Jan 15, 2014

Member

@sindresorhus: That sounds like a good idea.

Member

michaelficarra commented Jan 15, 2014

@sindresorhus: That sounds like a good idea.

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Jan 16, 2014

Member

I can buy that for additional formatters, however, I feel that the default
formatter should be part of the main codebase. We can't have a critical
part of the default behavior moving at a different rate than the rest of
the codebase.

So we can either pull the stylish formatter in and use it as a default, or
else there is probably no work to be done here.

Member

nzakas commented Jan 16, 2014

I can buy that for additional formatters, however, I feel that the default
formatter should be part of the main codebase. We can't have a critical
part of the default behavior moving at a different rate than the rest of
the codebase.

So we can either pull the stylish formatter in and use it as a default, or
else there is probably no work to be done here.

@sindresorhus

This comment has been minimized.

Show comment
Hide comment
@sindresorhus

sindresorhus Jan 16, 2014

Contributor

@nzakas it's more the node way to keep these parts separate. I don't see why it would be moving slower than the rest. I would be happy to move the repo into the org.

But i don't really care. I would be happy to do a PR for it instead if that's what you want?

Contributor

sindresorhus commented Jan 16, 2014

@nzakas it's more the node way to keep these parts separate. I don't see why it would be moving slower than the rest. I would be happy to move the repo into the org.

But i don't really care. I would be happy to do a PR for it instead if that's what you want?

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Jan 16, 2014

Member

If you could send a PR, that would be awesome. :)

Member

nzakas commented Jan 16, 2014

If you could send a PR, that would be awesome. :)

@nzakas nzakas closed this in #527 Jan 17, 2014

nzakas added a commit that referenced this issue Jan 17, 2014

Merge pull request #527 from sindresorhus/add-stylish-formatter
Add Stylish formatter and make it default. Fixes #517

@eslint eslint bot locked and limited conversation to collaborators Feb 7, 2018

@eslint eslint bot added the archived due to age label Feb 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.