New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run perf goes crazy #5330

Closed
nzakas opened this Issue Feb 18, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@nzakas
Member

nzakas commented Feb 18, 2016

I just pull the master branch and tried to run npm run perf. It goes crazy outputing thousands of lint errors to the console (20,451 to be exact) and then throws an error "Performance test failed".

I haven't kept a good eye on the change to npm run perf, but it's definitely not supposed to be outputting lint messages to the console.

@btmills

This comment has been minimized.

Show comment
Hide comment
@btmills

btmills Feb 19, 2016

Member

Working on this. I've narrowed down the break to b32ddad. Working on a fix now.

Member

btmills commented Feb 19, 2016

Working on this. I've narrowed down the break to b32ddad. Working on a fix now.

btmills added a commit that referenced this issue Feb 19, 2016

btmills added a commit that referenced this issue Feb 19, 2016

ilyavolodin added a commit that referenced this issue Mar 1, 2016

Merge pull request #5331 from eslint/issue5330
Build: Stop checking exit code in performance tests (fixes #5330)

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.