New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request check incorrectly marking valid commit messages as invalid #5340

Closed
nzakas opened this Issue Feb 19, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@nzakas
Member

nzakas commented Feb 19, 2016

It looks like the commit message check is not exactly correct on pull requests. Right now, it incorrectly assumes that the commit message is just one line, so this will trigger the max length warning and the warning about a missing issue reference:

Fix: Description (fixes #1234)

Fixed something bad

The solution is to only take the first line of the commit message and validate that, leaving the rest alone.

@nzakas nzakas self-assigned this Feb 19, 2016

ilyavolodin added a commit that referenced this issue Feb 19, 2016

Merge pull request #5341 from eslint/issue5340
Build: Fix commit message validation (fixes #5340)

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.