New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 tests are failing with espree v3.1.0 #5405

mysticatea opened this Issue Feb 26, 2016 · 0 comments


None yet
1 participant

mysticatea commented Feb 26, 2016

On the current master branch, 2 tests are failing.

  • keyword-spacing valid function* foo() { (() =>yield foo) }:
  • keyword-spacing valid function* foo() { (() => yield foo) }:

Since arrow functions cannot become generator functions, we cannot use yield expression in arrow functions. (on old espree implementation, that has been allowed wrongly.)
I will fix this...

@mysticatea mysticatea self-assigned this Feb 26, 2016

mysticatea added a commit to mysticatea/eslint that referenced this issue Feb 26, 2016

Fix: remove tests which have invalid syntax (fixes eslint#5405)
espree v3.1.0 came to raise a syntax error correctly at `yield` keyword
inside of arrow functions.

ilyavolodin added a commit that referenced this issue Feb 26, 2016

Merge pull request #5406 from mysticatea/keyword-spacing/fix-invalid-…

Fix: remove tests which have invalid syntax (fixes #5405)

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.