--no-ignore should not un-ignore node_modules

[IanVS]

What version of ESLint are you using?
Master

What configuration and parser (Espree, Babel-ESLint, etc.) are you using?
Espree

What did you do? Please include the actual source code causing the issue.
Ran eslint with --no-ignore flag

What did you expect to happen?
Ignore settings from .eslintignore to be disregarded, as indicated in docs.

What actually happened? Please include the actual, raw output from ESLint.
ESLint linted all files within node_modules.

Despite having tests to assert that --no-ignore will cause node_modules to be linted, I think this is not the behavior we expect or want.

The --no-ignore docs say:

--no-ignore
Disables excluding of files from .eslintignore and --ignore-path files.

They don't say anything about also disabling default ignores.

After #5410 is fixed, it will be possible to lint within node_modules by using a negation pattern. (e.g. !/node_modules/package-to-lint/), at which time I think it would make sense to keep --no-ignore from linting /node_modules/ and /bower_components/.

Does the team agree?

[ilyavolodin]

Agree.

[alberto]

Wouldn't this be a breaking change?

[IanVS]

Personally I see it as a bug fix, since the current behavior is not as
documented or expected.

On Fri, Mar 11, 2016, 12:37 alberto notifications@github.com wrote:

Wouldn't this be a breaking change?

—
Reply to this email directly or view it on GitHub
#5547 (comment).

[alberto]

I just realized that if --no-ignore ignores .eslintignore files, it won't be possible to uningnore anything at the same time 😅

[platinumazure]

@alberto Is that really so, given one could specify ignore patterns in the CLI using --ignore-pattern?

[nzakas]

--no-ignore is mostly used for testing purposes (at least, that's why it was added, IIRC). I agree, this seems like a bug that was leftover after the ignore file refactoring.

[alberto]

@platinumazure not very intuitive, but 👍 given the context.

[IanVS]

Unfortunately it looks like #5648 did not fully fix this issue. It addressed it inside of ignored-paths.js, but we also do some checking for options.ignore in cli-engine.js in isPathIgnored() and executeOnText().

Testing manually on the cli reveals that --no-ignore still causes node_modules to be linted as before.

[nzakas]

So this would only affect people using the API?

[IanVS]

The fix only was made in ignored-paths, which caused its own tests to pass. The ESLint API and CLI are still broken.

[alberto]

Ooops, sorry. I would swear I had also manually tested it... :(

[IanVS]

Working on this.