New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify most popular presets for JSCS #5858

Closed
nzakas opened this Issue Apr 14, 2016 · 65 comments

Comments

@nzakas
Member

nzakas commented Apr 14, 2016

One thing JSCS has that ESLint does not is the concept of built-in style presets. ESLint instead prefers people to make and maintain their own shareable configs. The current JSCS presets are:

  • Airbnb (eslint-config-airbnb)
  • Crockford
  • Google (eslint-config-google)
  • Grunt (eslint-config-grunt)
  • Idiomatic (eslint-config-idiomatic)
  • jQuery (eslint-config-jquery)
  • MDCS
  • Node Style Guide (node-style-guide)
  • Wikimedia (eslint-config-wikimedia)
  • Wordpress (eslint-config-wordpress)

It would be good to see which of these presets are most commonly used and potentially reach out to the various projects (Node, jQuery, Grunt, etc.) to see if they would be interested in creating a shareable config that can be used with ESLint.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Apr 18, 2016

Member

I can say about jQuery - i already send announcement about it to jquery people so i will re-create preset with eslint rules very soon. Do we need a ticket specifically about this?

As of other presets, i can probably come up with the list of others missing presets and do them too. Some of the will be easy to do, since, for example, grunt preset inherits jquery preset.

Member

markelog commented Apr 18, 2016

I can say about jQuery - i already send announcement about it to jquery people so i will re-create preset with eslint rules very soon. Do we need a ticket specifically about this?

As of other presets, i can probably come up with the list of others missing presets and do them too. Some of the will be easy to do, since, for example, grunt preset inherits jquery preset.

@ntwb

This comment has been minimized.

Show comment
Hide comment
@ntwb

ntwb Apr 18, 2016

Contributor

I converted the JSCS WordPress preset yesterday into this .eslintrc file based of the combined WordPress preset that inherits the jQuery preset resulting in this combined .jscsrc file

I plan on at some stage this week once I've some time to update eslint-config-wordpress with a JSCS configuration as an alternate to the current configuration.

Contributor

ntwb commented Apr 18, 2016

I converted the JSCS WordPress preset yesterday into this .eslintrc file based of the combined WordPress preset that inherits the jQuery preset resulting in this combined .jscsrc file

I plan on at some stage this week once I've some time to update eslint-config-wordpress with a JSCS configuration as an alternate to the current configuration.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Apr 18, 2016

Member

Awesome sauce already!

Regards,
Oleg

On 18 апр. 2016 г., at 14:25, Stephen Edgar notifications@github.com wrote:

I converted the JSCS WordPress preset yesterday into this .eslintrc file based of the combined WordPress preset that inherits the jQuery preset resulting in this combined .jscsrc file

I plan on at some stage this week once I've some time to update eslint-config-wordpress with a JSCS configuration as an alternate to the current configuration.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub

Member

markelog commented Apr 18, 2016

Awesome sauce already!

Regards,
Oleg

On 18 апр. 2016 г., at 14:25, Stephen Edgar notifications@github.com wrote:

I converted the JSCS WordPress preset yesterday into this .eslintrc file based of the combined WordPress preset that inherits the jQuery preset resulting in this combined .jscsrc file

I plan on at some stage this week once I've some time to update eslint-config-wordpress with a JSCS configuration as an alternate to the current configuration.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub

@ilyavolodin

This comment has been minimized.

Show comment
Hide comment
@ilyavolodin

ilyavolodin Apr 18, 2016

Member

@markelog I don't think we need a separate issue for each one. Since each one will be created as an individual npm module, we can just use this issue to maybe update --init command once all of the presets exist.

Member

ilyavolodin commented Apr 18, 2016

@markelog I don't think we need a separate issue for each one. Since each one will be created as an individual npm module, we can just use this issue to maybe update --init command once all of the presets exist.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Apr 18, 2016

Member

We could redo a ticket description as checkbox list, any approach is fine with me however.

Member

markelog commented Apr 18, 2016

We could redo a ticket description as checkbox list, any approach is fine with me however.

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Apr 18, 2016

Member

@markelog will the jQuery folks be able to maintain the config?

A larger question here is where do we want the configs to be stored? If we plan to hand them off to the respective projects, then they should each be a separate repo.

Member

nzakas commented Apr 18, 2016

@markelog will the jQuery folks be able to maintain the config?

A larger question here is where do we want the configs to be stored? If we plan to hand them off to the respective projects, then they should each be a separate repo.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Apr 18, 2016

Member

@markelog will the jQuery folks be able to maintain the config?

We would need to discuss that, but it seems we will, currently, i will put it under my account.

If we plan to hand them off to the respective projects, then they should each be a separate repo.

Yeah, that was my thinking too - "/cc" everyone (like any org/person) related to presets (if they don't already exist). Obviously, presets like "Crockford" would be maintained by someone else. I guess that could be me at the moment, can transfer that responsibility to any interested parties however.

Member

markelog commented Apr 18, 2016

@markelog will the jQuery folks be able to maintain the config?

We would need to discuss that, but it seems we will, currently, i will put it under my account.

If we plan to hand them off to the respective projects, then they should each be a separate repo.

Yeah, that was my thinking too - "/cc" everyone (like any org/person) related to presets (if they don't already exist). Obviously, presets like "Crockford" would be maintained by someone else. I guess that could be me at the moment, can transfer that responsibility to any interested parties however.

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Apr 18, 2016

Member

@markelog sounds good. You can always put a note in the readme that you're looking for a maintainer and we can publicize that using the Twitter account and the blog as well.

Member

nzakas commented Apr 18, 2016

@markelog sounds good. You can always put a note in the readme that you're looking for a maintainer and we can publicize that using the Twitter account and the blog as well.

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Apr 18, 2016

Member

@ntwb awesome, thanks!

Member

nzakas commented Apr 18, 2016

@ntwb awesome, thanks!

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Apr 18, 2016

Member

https://github.com/jquery/eslint-config-jquery is created btw, so yeah, jQuery Foundation will support eslint config.

@nzakas cool!

Member

markelog commented Apr 18, 2016

https://github.com/jquery/eslint-config-jquery is created btw, so yeah, jQuery Foundation will support eslint config.

@nzakas cool!

@alberto

This comment has been minimized.

Show comment
Hide comment
@alberto

alberto Apr 21, 2016

Member

Does it mean we can close #632 ? It's our oldest issue :)

Member

alberto commented Apr 21, 2016

Does it mean we can close #632 ? It's our oldest issue :)

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Apr 21, 2016

Member

@alberto we had one open question on that. It would be good to get it answered before closing (do people really not indent a top-level IIFE?)

Member

nzakas commented Apr 21, 2016

@alberto we had one open question on that. It would be good to get it answered before closing (do people really not indent a top-level IIFE?)

@alberto

This comment has been minimized.

Show comment
Hide comment
@alberto

alberto Apr 21, 2016

Member

Yeah, that's why am asking ;)

Member

alberto commented Apr 21, 2016

Yeah, that's why am asking ;)

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Apr 22, 2016

Member

We need to ask someone at jQuery, not me :)

Member

nzakas commented Apr 22, 2016

We need to ask someone at jQuery, not me :)

@alberto

This comment has been minimized.

Show comment
Hide comment
@alberto

alberto Apr 22, 2016

Member

yeah, that's was more of a question for @markelog :)

Member

alberto commented Apr 22, 2016

yeah, that's was more of a question for @markelog :)

@ntwb

This comment has been minimized.

Show comment
Hide comment
@ntwb

ntwb Apr 24, 2016

Contributor

I've added the JSCS config mentioned above as a shared config to eslint-plugin-wordpress

Now to just write up some docs on using the said shared config and release 🎉

Contributor

ntwb commented Apr 24, 2016

I've added the JSCS config mentioned above as a shared config to eslint-plugin-wordpress

Now to just write up some docs on using the said shared config and release 🎉

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Apr 27, 2016

Member

@ntwb cool! Add you going to update eslint-config-wordpress as well?

Either way, we can add this to our --init menu and eventual conversion of JSCS configs.

Member

nzakas commented Apr 27, 2016

@ntwb cool! Add you going to update eslint-config-wordpress as well?

Either way, we can add this to our --init menu and eventual conversion of JSCS configs.

@ntwb

This comment has been minimized.

Show comment
Hide comment
@ntwb

ntwb Apr 27, 2016

Contributor

@nzakas Yes, I'm going to update eslint-config-wordpress so that it extends the eslint-plugin-wordpress:recommended config, I'm just time poor at the moment, hopefully within the next day or two

Contributor

ntwb commented Apr 27, 2016

@nzakas Yes, I'm going to update eslint-config-wordpress so that it extends the eslint-plugin-wordpress:recommended config, I'm just time poor at the moment, hopefully within the next day or two

@jdforrester

This comment has been minimized.

Show comment
Hide comment
@jdforrester

jdforrester May 17, 2016

Wikimedia is also a current jscs preset, BTW. :-)

jdforrester commented May 17, 2016

Wikimedia is also a current jscs preset, BTW. :-)

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas
Member

nzakas commented May 17, 2016

@markelog

This comment has been minimized.

Show comment
Hide comment
Member

markelog commented May 17, 2016

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog May 17, 2016

Member

@jdforrester do you want to create eslint config yourself? Or maybe you already did it?

Member

markelog commented May 17, 2016

@jdforrester do you want to create eslint config yourself? Or maybe you already did it?

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas May 17, 2016

Member

Ooh tricky!

Member

nzakas commented May 17, 2016

Ooh tricky!

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog May 17, 2016

Member

@nzakas ideas was to move all presets to external dependencies

Member

markelog commented May 17, 2016

@nzakas ideas was to move all presets to external dependencies

@jdforrester

This comment has been minimized.

Show comment
Hide comment
@jdforrester

jdforrester May 17, 2016

@markelog We've not created an eslint config preset yet for Wikimedia; I was kinda-hoping you lot would show the way forward so we could do it more easily. :-) No huge rush from our end.

jdforrester commented May 17, 2016

@markelog We've not created an eslint config preset yet for Wikimedia; I was kinda-hoping you lot would show the way forward so we could do it more easily. :-) No huge rush from our end.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Jul 26, 2016

Member

I'm not sure if crockford and mdcs require eslint packages, they do not seem popular, looking back at it, I'm puzzled of why we added crockford preset, since there is such thing as jslint.

Thoughts?

Member

markelog commented Jul 26, 2016

I'm not sure if crockford and mdcs require eslint packages, they do not seem popular, looking back at it, I'm puzzled of why we added crockford preset, since there is such thing as jslint.

Thoughts?

@platinumazure

This comment has been minimized.

Show comment
Hide comment
@platinumazure

platinumazure Jul 26, 2016

Member

The issue is mostly about adding popular presets, so (just from my own perspective) I feel we could avoid adding Crockford until requested, at least.

Member

platinumazure commented Jul 26, 2016

The issue is mostly about adding popular presets, so (just from my own perspective) I feel we could avoid adding Crockford until requested, at least.

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Jul 26, 2016

Member

@markelog the original description just listed out all of the supported JSCS presets so we could decide which ones to support. If you feel those two aren't popular enough then we definitely don't need them.

Member

nzakas commented Jul 26, 2016

@markelog the original description just listed out all of the supported JSCS presets so we could decide which ones to support. If you feel those two aren't popular enough then we definitely don't need them.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Jul 26, 2016

Member

Okay, then sounds like we good here.

@nzakas what do you think we should do with this issue? Should we close it and open different one for the --init flag? Or deal with it here?

Member

markelog commented Jul 26, 2016

Okay, then sounds like we good here.

@nzakas what do you think we should do with this issue? Should we close it and open different one for the --init flag? Or deal with it here?

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Jul 26, 2016

Member

@markelog I'd say just deal with it here, as it gives a nice close to the discussion and work.

Member

nzakas commented Jul 26, 2016

@markelog I'd say just deal with it here, as it gives a nice close to the discussion and work.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Jul 29, 2016

Member

Okay, so what configs we want to add (right now we have Google, Airbnb and Standard)?

All available ones? Or we should cherry-pick?

At this point, I'm not sure if wikimedia people are happy with their config (@jdforrester?). I would suppose jquery might be good fit there? /cc @scottgonzalez, @timmywil, @dmethvin.

Maybe idiomatic /cc @rwaldron, @leobalter?

Wordpress?

Or never mind that and all of them?

Member

markelog commented Jul 29, 2016

Okay, so what configs we want to add (right now we have Google, Airbnb and Standard)?

All available ones? Or we should cherry-pick?

At this point, I'm not sure if wikimedia people are happy with their config (@jdforrester?). I would suppose jquery might be good fit there? /cc @scottgonzalez, @timmywil, @dmethvin.

Maybe idiomatic /cc @rwaldron, @leobalter?

Wordpress?

Or never mind that and all of them?

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter Jul 29, 2016

@markelog QUnit follows the jQuery Code Style, so I'm +1 for jquery.

leobalter commented Jul 29, 2016

@markelog QUnit follows the jQuery Code Style, so I'm +1 for jquery.

@ntwb

This comment has been minimized.

Show comment
Hide comment
@ntwb

ntwb Jul 29, 2016

Contributor

Wordpress?

Not yet, I'm half way through refactoring much of the WordPress config.

(That said, I'm hoping I'll have it finished this weekend)

Contributor

ntwb commented Jul 29, 2016

Wordpress?

Not yet, I'm half way through refactoring much of the WordPress config.

(That said, I'm hoping I'll have it finished this weekend)

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Aug 2, 2016

Member

@nzakas friendly ping

Member

markelog commented Aug 2, 2016

@nzakas friendly ping

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Aug 2, 2016

Member

@markelog I'd defer to your opinion on this. I'd like to keep the list to things we know people will use rather than just including them all. Do you have a sense of what the most popular JSCS ones were?

Member

nzakas commented Aug 2, 2016

@markelog I'd defer to your opinion on this. I'd like to keep the list to things we know people will use rather than just including them all. Do you have a sense of what the most popular JSCS ones were?

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Aug 2, 2016

Member

A bit, I even did the comparison - https://github.com/markelog/code-styles

It's good we have 3rd party configs which could replace JSCS ones, but to be honest, I don't think any of those code styles should be included -

  • Grunt is very project specific code style, not strictly speaking defined and not very known
  • Wordpress could be a good choice but it seems it is not known at all
  • jQuery could be a good choice, but at the moment only jQuery Core uses it, there might be some big issues when or if it would be implemented in other projects, like some of the foundation members advocating to just use Standard
  • Wikimedia pretty much same story as with jQuery
  • Idiomatic is relatively popular, but i remember that author @rwaldron was advocating to use Airbnb instead

When I say "popular" or "known" i mean amount of npm downloads and github stars. Most popular presets in JSCS were Google and Airbnb, which already included in the ESLint

Member

markelog commented Aug 2, 2016

A bit, I even did the comparison - https://github.com/markelog/code-styles

It's good we have 3rd party configs which could replace JSCS ones, but to be honest, I don't think any of those code styles should be included -

  • Grunt is very project specific code style, not strictly speaking defined and not very known
  • Wordpress could be a good choice but it seems it is not known at all
  • jQuery could be a good choice, but at the moment only jQuery Core uses it, there might be some big issues when or if it would be implemented in other projects, like some of the foundation members advocating to just use Standard
  • Wikimedia pretty much same story as with jQuery
  • Idiomatic is relatively popular, but i remember that author @rwaldron was advocating to use Airbnb instead

When I say "popular" or "known" i mean amount of npm downloads and github stars. Most popular presets in JSCS were Google and Airbnb, which already included in the ESLint

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter Aug 2, 2016

@markelog how did you measure the popularity? The code style guide for jQuery might have a unpopular own repo, and as jQuery projects are only migrating now to ESLint I believe they won't have much explicit numbers.

I don't think it's necessary to land the jQuery preset with eslint core, we can solve it with an extra npm package. My only concern is how the proposed support from ESLint applies in this issue.

leobalter commented Aug 2, 2016

@markelog how did you measure the popularity? The code style guide for jQuery might have a unpopular own repo, and as jQuery projects are only migrating now to ESLint I believe they won't have much explicit numbers.

I don't think it's necessary to land the jQuery preset with eslint core, we can solve it with an extra npm package. My only concern is how the proposed support from ESLint applies in this issue.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Aug 2, 2016

Member

@markelog how did you measure the popularity?

aam, from #5858 (comment)

When I say "popular" or "known" i mean amount of npm downloads and github stars.

jQuery projects are only migrating now to ESLint I believe they won't have much explicit numbers.

That's the thing - I don't know if they will, as i said, some influential people from foundation lobbying to use Standard instead, I think it is safe to say that QUnit and Sizzle will switch it up, but that's it. So at this point of time, I just don't have any guarantees it will be accepted by the others member of the foundation.

Safe bet was to include Google or Airbnb (which already happened), their popularity is obvious from JSCS traffic page, but not so much for other styles, others were waaay behind

we can solve it with an extra npm package

ESLint by itself would not include additional packages with it, it can present some configs as an option at eslint --init and install it if chosen, so additional package would still be needed

Member

markelog commented Aug 2, 2016

@markelog how did you measure the popularity?

aam, from #5858 (comment)

When I say "popular" or "known" i mean amount of npm downloads and github stars.

jQuery projects are only migrating now to ESLint I believe they won't have much explicit numbers.

That's the thing - I don't know if they will, as i said, some influential people from foundation lobbying to use Standard instead, I think it is safe to say that QUnit and Sizzle will switch it up, but that's it. So at this point of time, I just don't have any guarantees it will be accepted by the others member of the foundation.

Safe bet was to include Google or Airbnb (which already happened), their popularity is obvious from JSCS traffic page, but not so much for other styles, others were waaay behind

we can solve it with an extra npm package

ESLint by itself would not include additional packages with it, it can present some configs as an option at eslint --init and install it if chosen, so additional package would still be needed

@platinumazure

This comment has been minimized.

Show comment
Hide comment
@platinumazure

platinumazure Aug 2, 2016

Member

@leobalter I'm still willing to get QUnit moved to ESLint, I'm just waiting for some dust to settle in eslint-config-jquery first. Sorry for the delay on that front.

Member

platinumazure commented Aug 2, 2016

@leobalter I'm still willing to get QUnit moved to ESLint, I'm just waiting for some dust to settle in eslint-config-jquery first. Sorry for the delay on that front.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Aug 2, 2016

Member

@leobalter I'm still willing to get QUnit moved to ESLint, I'm just waiting for some dust to settle in eslint-config-jquery first. Sorry for the delay on that front.

Dust is settled it is now 1.0 (for the record i'm also maintaining eslint-config-jquery)

Member

markelog commented Aug 2, 2016

@leobalter I'm still willing to get QUnit moved to ESLint, I'm just waiting for some dust to settle in eslint-config-jquery first. Sorry for the delay on that front.

Dust is settled it is now 1.0 (for the record i'm also maintaining eslint-config-jquery)

@leobalter

This comment has been minimized.

Show comment
Hide comment
@leobalter

leobalter Aug 2, 2016

I'm still willing to get QUnit moved to ESLint, I'm just waiting for some dust to settle in eslint-config-jquery first. Sorry for the delay on that front.

I'm expecting that to happen soon. I hope it can give a better expectation and perspective to this issue.

leobalter commented Aug 2, 2016

I'm still willing to get QUnit moved to ESLint, I'm just waiting for some dust to settle in eslint-config-jquery first. Sorry for the delay on that front.

I'm expecting that to happen soon. I hope it can give a better expectation and perspective to this issue.

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Aug 3, 2016

Member

We definitely don't have to add any new configs to --init. It might be enough to start a JSCS migration guide and just list out the shareable config that represents each style.

Does Polyjuice deal with presets at all?

Member

nzakas commented Aug 3, 2016

We definitely don't have to add any new configs to --init. It might be enough to start a JSCS migration guide and just list out the shareable config that represents each style.

Does Polyjuice deal with presets at all?

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Aug 12, 2016

Member

Okay, sounds like we good here, documentation related stuff will be handled in #5859

Member

markelog commented Aug 12, 2016

Okay, sounds like we good here, documentation related stuff will be handled in #5859

@markelog markelog closed this Aug 12, 2016

@brenolf

This comment has been minimized.

Show comment
Hide comment
@brenolf

brenolf Aug 18, 2016

Being Polyjuice's only maintainer, it's been hard for me to be pedantic with some mappings, I'm sorry!

I've just solved @markelog opened issues, but some rules weren't changed given that I do believe Polyjuice's aim is more related to be a fast and flexible way of migrating instead of a 1-1 mapper; so the output must be further analyzed if that's a major concern of the user.

@nzakas No it doesn't deal with presets, just with a json file for rules. Nevertheless, if that would make the transpiling easier, I'd be willing to add that feature.

brenolf commented Aug 18, 2016

Being Polyjuice's only maintainer, it's been hard for me to be pedantic with some mappings, I'm sorry!

I've just solved @markelog opened issues, but some rules weren't changed given that I do believe Polyjuice's aim is more related to be a fast and flexible way of migrating instead of a 1-1 mapper; so the output must be further analyzed if that's a major concern of the user.

@nzakas No it doesn't deal with presets, just with a json file for rules. Nevertheless, if that would make the transpiling easier, I'd be willing to add that feature.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Aug 18, 2016

Member

Being Polyjuice's only maintainer, it's been hard for me to be pedantic with some mappings, I'm sorry!

I think it is perfectly fine, this kind of mapping is long and sometimes tedious process, so there is no surprise, polyjuice is tremendously helpful anyhow

@nzakas No it doesn't deal with presets, just with a json file for rules. Nevertheless, if that would make the transpiling easier, I'd be willing to add that feature.

Technically speaking you can already do that, like -

polyjuice --jscs node_modules/jscs/presets/crockford.json .jscsrc > .eslintrc

and people with custom presets probably will figure out such workaround, could be added to the docs though

Member

markelog commented Aug 18, 2016

Being Polyjuice's only maintainer, it's been hard for me to be pedantic with some mappings, I'm sorry!

I think it is perfectly fine, this kind of mapping is long and sometimes tedious process, so there is no surprise, polyjuice is tremendously helpful anyhow

@nzakas No it doesn't deal with presets, just with a json file for rules. Nevertheless, if that would make the transpiling easier, I'd be willing to add that feature.

Technically speaking you can already do that, like -

polyjuice --jscs node_modules/jscs/presets/crockford.json .jscsrc > .eslintrc

and people with custom presets probably will figure out such workaround, could be added to the docs though

@brenolf

This comment has been minimized.

Show comment
Hide comment
@brenolf

brenolf Aug 18, 2016

@markelog In fact this usage with multiple files is not allowed in the moment. However, given your example I'll be adding it right now.

brenolf commented Aug 18, 2016

@markelog In fact this usage with multiple files is not allowed in the moment. However, given your example I'll be adding it right now.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Aug 18, 2016

Member

Oh there is a typo, i meant to write -

polyjuice --jscs node_modules/jscs/presets/crockford.json > .eslintrc
Member

markelog commented Aug 18, 2016

Oh there is a typo, i meant to write -

polyjuice --jscs node_modules/jscs/presets/crockford.json > .eslintrc
@zz85

This comment has been minimized.

Show comment
Hide comment
@zz85

zz85 Nov 15, 2016

Contributor

Wish I've seen this thread earlier and could have saved me some trouble if learned about Polyjuice! I've just hand ported MDCS code style from to ESLint but maybe I should make an npm module for this config. http://zz85.github.io/mrdoobapproves/

Contributor

zz85 commented Nov 15, 2016

Wish I've seen this thread earlier and could have saved me some trouble if learned about Polyjuice! I've just hand ported MDCS code style from to ESLint but maybe I should make an npm module for this config. http://zz85.github.io/mrdoobapproves/

@zz85

This comment has been minimized.

Show comment
Hide comment
@zz85

zz85 Nov 16, 2016

Contributor

Update: MDCS eslint-config-mdcs is now an npm module. @markelog

Contributor

zz85 commented Nov 16, 2016

Update: MDCS eslint-config-mdcs is now an npm module. @markelog

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.