New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in the CLIEngine.getErrorResults(report.results) returned array of objects. #6155

Closed
Xflofoxx opened this Issue May 13, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@Xflofoxx

Xflofoxx commented May 13, 2016

What version of ESLint are you using?
eslint@2.9.0
What parser (default, Babel-ESLint, etc.) are you using?
babel-eslint@6.0.4

What did you do? Please include the actual source code causing the issue.
I'm using the grunt-eslint module that do this call:

var results = report.results;
if (opts.quiet) {
    results = eslint.CLIEngine.getErrorResults(results);
}
var output = formatter(results);

What did you expect to happen?
I think it should filter the results getting only the "errors".

What actually happened? Please include the actual, raw output from ESLint.
The problem is that the function getErrorResults(results) only returns the filePath: and messages key, while the original report.results passed to the function contains also errorCount and warningCount keys.

Am I missing something?
Thanks.

eslint-html-formatter-error

@eslintbot eslintbot added the triage label May 13, 2016

@alberto alberto added bug core accepted and removed triage labels May 13, 2016

@alberto

This comment has been minimized.

Show comment
Hide comment
@alberto

alberto May 13, 2016

Member

Confirmed using --quiet breaks the output of some formatters.

Working on this.

Member

alberto commented May 13, 2016

Confirmed using --quiet breaks the output of some formatters.

Working on this.

@alberto alberto self-assigned this May 13, 2016

alberto added a commit that referenced this issue May 13, 2016

@gyandeeps gyandeeps closed this in 2166ad4 May 14, 2016

@eslint eslint bot locked and limited conversation to collaborators Feb 6, 2018

@eslint eslint bot added the archived due to age label Feb 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.