Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix typos,wrong path,backticks #6663

Merged
merged 1 commit into from Jul 15, 2016
Merged

Docs: fix typos,wrong path,backticks #6663

merged 1 commit into from Jul 15, 2016

Conversation

molee1905
Copy link
Contributor

What issue does this pull request address?

docs fixed

What changes did you make? (Give an overview)

fix typos,wrong path,backticks.

for example: in the rule no-undefined

image

Is there anything you'd like reviewers to focus on?

no

@mention-bot
Copy link

@molee1905, thanks for your PR! By analyzing the annotation information on this pull request, we identified @pedrottimark, @nzakas and @michaelficarra to be potential reviewers

@eslintbot
Copy link

LGTM

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@molee1905
Copy link
Contributor Author

image

image

Could anyone tell me how can i pass the CLA Verification?

@ilyavolodin
Copy link
Member

@kborchers could you help us with CLA again please?

@ilyavolodin
Copy link
Member

LGTM. Thanks for PR. Waiting for CLA to be resolved before merging.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jul 13, 2016

@molee1905 I recently had a similar problem with CLA, maybe some tips there could help.

@nzakas
Copy link
Member

nzakas commented Jul 13, 2016

@molee1905 you can't use your username as the name you sign the CLA with, it has to be an actual human name.

@kborchers
Copy link

Since we will be modifying the name check soon, I went ahead and added an exception to the signature and reran the check. Should be all set now and sorry for the delay.

@molee1905
Copy link
Contributor Author

molee1905 commented Jul 14, 2016

Thanks all !

Sign Electronically

The name and email address used to sign the CLA must match the name and email address in your git config. The author information for each commit in your Contributions will be cross-checked with this signature.

The CLA just requires the name and email mach the name and email address in one's git config, dose not require an actual human name; in my config, the name and username both are molee1905, so there is no problem with the CLA's requirements.

i'am not the only one to be labeled CLA: Error with correct operation according to the CLA's requirement , maybe, the rule to sign the CLA successfully should be described in more detail,and it will be better to change the way of manual verification.

Hoping the change!

@ilyavolodin
Copy link
Member

Thanks @kborchers for your help! LGTM. Thanks for PR @molee1905

@ilyavolodin ilyavolodin merged commit 089ee2c into eslint:master Jul 15, 2016
@molee1905 molee1905 deleted the fixdocv3.0.0 branch July 15, 2016 02:09
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants