Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: describe all RuleTester options (fixes #4810) #6711

Merged
merged 1 commit into from Jul 21, 2016
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jul 19, 2016

What issue does this pull request address?
#4810, #6709

What changes did you make? (Give an overview)

Added descriptions for parser, settings, and globals to test descriptions. Also added mention of using line and column for invalid tests.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@nzakas, thanks for your PR! By analyzing the annotation information on this pull request, we identified @platinumazure, @alberto and @evangoer to be potential reviewers

@platinumazure
Copy link
Member

Per #6709, perhaps you might want to add a reference to filename as well? That way you could kill two issues with one PR.

@nzakas
Copy link
Member Author

nzakas commented Jul 19, 2016

Yeah, good call.

@eslintbot
Copy link

LGTM

@ilyavolodin
Copy link
Member

LGTM, but waiting another day for others to look

@gyandeeps
Copy link
Member

LGTM, waiting for others to review.

@nzakas nzakas merged commit e09d1b8 into master Jul 21, 2016
@nzakas nzakas deleted the issue4810 branch July 21, 2016 16:10
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants