Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Clean up sort-var #7045

Merged
merged 1 commit into from Sep 3, 2016
Merged

Docs: Clean up sort-var #7045

merged 1 commit into from Sep 3, 2016

Conversation

matthewdunsdon
Copy link
Contributor

@matthewdunsdon matthewdunsdon commented Sep 2, 2016

What issue does this pull request address?

Documentation readability

What changes did you make? (Give an overview)

  • Made incorrect and correct examples for sort-var clearer
  • Simplified description of options, including clarifying the default behavior.

Is there anything you'd like reviewers to focus on?

No.

@mention-bot
Copy link

@matthewdunsdon, thanks for your PR! By analyzing the annotation information on this pull request, we identified @IanVS, @lo1tuma and @ilyavolodin to be potential reviewers

@eslintbot
Copy link

LGTM

@platinumazure
Copy link
Member

LGTM but would like others to review.


### `ignoreCase`
* `"ignoreCase": false` (default) checks the case-sensitivity of the variables order
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you combine these bullets into one? We usually do one bullet per option name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made that change.

@eslintbot
Copy link

LGTM

@vitorbal
Copy link
Member

vitorbal commented Sep 3, 2016

Lgtm. Thanks, @matthewdunsdon!

@vitorbal vitorbal merged commit 52e8d9c into eslint:master Sep 3, 2016
@matthewdunsdon matthewdunsdon deleted the doc-enhancement/sort-vars branch September 3, 2016 14:16
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants