New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change .eslintignore to plain text #761

Closed
nzakas opened this Issue Apr 4, 2014 · 7 comments

Comments

Projects
None yet
3 participants
@nzakas
Member

nzakas commented Apr 4, 2014

Our .eslintignore file is currently JSON. I'd like to change it to plain text (matching JSHint's version) for simplicity. I don't think JSON adds much value in this context when plain text with each line representing a path will do.

This would be a breaking change, so we'd need to wait until 0.5.0 to push it out.

@btmills

This comment has been minimized.

Show comment
Hide comment
@btmills

btmills Apr 11, 2014

Member

Working on this. Rather than waiting to push a breaking change, how about deprecating JSON but still attempting to parse it before using plain text, then removing JSON entirely later?

Member

btmills commented Apr 11, 2014

Working on this. Rather than waiting to push a breaking change, how about deprecating JSON but still attempting to parse it before using plain text, then removing JSON entirely later?

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Apr 11, 2014

Member

I like that.

Member

nzakas commented Apr 11, 2014

I like that.

@btmills

This comment has been minimized.

Show comment
Hide comment
@btmills

btmills Apr 13, 2014

Member

Cool. How desirable is it to mirror .gitignore syntax, perhaps using ignore?

Member

btmills commented Apr 13, 2014

Cool. How desirable is it to mirror .gitignore syntax, perhaps using ignore?

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Apr 13, 2014

Member

I wouldn't bundle git ignore syntax with this change. Right now we just do globs, and I think that's good enough for our use case.

Member

nzakas commented Apr 13, 2014

I wouldn't bundle git ignore syntax with this change. Right now we just do globs, and I think that's good enough for our use case.

@michaelficarra

This comment has been minimized.

Show comment
Hide comment
@michaelficarra

michaelficarra Apr 13, 2014

Member

kaelzhang/node-ignore would handle everything for us, though.

Member

michaelficarra commented Apr 13, 2014

kaelzhang/node-ignore would handle everything for us, though.

@nzakas

This comment has been minimized.

Show comment
Hide comment
@nzakas

nzakas Apr 13, 2014

Member

As I said, I don't want to bundle a pattern change along with a format change. You can open a separate issue if you feel strongly that a pattern change is needed.

Member

nzakas commented Apr 13, 2014

As I said, I don't want to bundle a pattern change along with a format change. You can open a separate issue if you feel strongly that a pattern change is needed.

@btmills

This comment has been minimized.

Show comment
Hide comment
@btmills

btmills Apr 13, 2014

Member

Using kaelzhang/node-ignore would require more extensive changes to the code than I'm doing here, and it would require some code gymnastics to support JSON and full ignore syntax in parallel. Let's add that when JSON format support is removed entirely in a future release?

Member

btmills commented Apr 13, 2014

Using kaelzhang/node-ignore would require more extensive changes to the code than I'm doing here, and it would require some code gymnastics to support JSON and full ignore syntax in parallel. Let's add that when JSON format support is removed entirely in a future release?

btmills added a commit to btmills/eslint that referenced this issue Apr 13, 2014

Change .eslintingore to plain text (fixes #761)
This commit adds support for plain text .eslintignore files
containing one glob per line.  It maintains support for the
existing JSON format but adds a deprecation notice warning that it
will be removed in the future.

btmills added a commit to btmills/eslint that referenced this issue Apr 13, 2014

Change .eslintingore to plain text (fixes #761)
This commit adds support for plain text .eslintignore files
containing one glob per line.  It maintains support for the
existing JSON format but adds a deprecation notice warning that it
will be removed in the future.

btmills added a commit to btmills/eslint that referenced this issue Apr 13, 2014

Change .eslintingore to plain text (fixes #761)
This commit adds support for plain text .eslintignore files
containing one glob per line.  It maintains support for the
existing JSON format but adds a deprecation notice warning that it
will be removed in the future.

@nzakas nzakas closed this in 5967daf Apr 13, 2014

nzakas added a commit that referenced this issue Apr 13, 2014

Merge pull request #788 from btmills/eslintignore
Change .eslintingore to plain text (fixes #761)

@eslint eslint bot locked and limited conversation to collaborators Feb 7, 2018

@eslint eslint bot added the archived due to age label Feb 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.