New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple perf runs report last run's time, not median #804

Closed
michaelficarra opened this Issue Apr 17, 2014 · 0 comments

Comments

Projects
None yet
2 participants
@michaelficarra
Member

michaelficarra commented Apr 17, 2014

I'll fix this as part of my rewrite of #803.

michaelficarra added a commit to michaelficarra/eslint that referenced this issue Apr 17, 2014

fixes #804: clean up implementation of #803 (which fixed #781)
I also changed it to be median of 5, since it's now trivial to choose
any number of runs, and use a more reasonable PERF_MULTIPLIER of 5e6
since we're much less likely to have fluke spikes cause builds to fail.

michaelficarra added a commit to michaelficarra/eslint that referenced this issue Apr 17, 2014

fixes #804: clean up implementation of #803 (which fixed #781)
I also changed it to be median of 5, since it's now trivial to choose
any number of runs, and use a more reasonable PERF_MULTIPLIER of 6e6
since we're much less likely to have fluke spikes cause builds to fail.

@nzakas nzakas added the bug label Apr 17, 2014

@nzakas nzakas closed this in f86db90 Apr 17, 2014

nzakas added a commit that referenced this issue Apr 17, 2014

Merge pull request #805 from michaelficarra/GH-804
fixes #804: clean up implementation of #803 (which fixed #781)

@eslint eslint bot locked and limited conversation to collaborators Feb 7, 2018

@eslint eslint bot added the archived due to age label Feb 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.